Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#156): Manual implementations of PangoGravity functions #158

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@federicomenaquintero
Copy link
Contributor

federicomenaquintero commented Aug 14, 2019

Gravity is an enum, and so it didn't get its functions auto-generated
by gir.

Fixes #156

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 14, 2019

👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 14, 2019

Please add it into manual types in the Gir.toml file as well. Like that, if it's used somewhere else, it'll be generated automatically.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 14, 2019

Please add it into manual types in the Gir.toml file as well.

The type is autogenerated, but because it's an enum the functions of it are not.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 14, 2019

Really? If another type's method is using it, it's generating even if we don't put into manual?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 14, 2019

What do you want to add to manual? The type is already in generate :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 14, 2019

Oh indeed! I was sure I saw the type declaration... Is it expected that those methods aren't generated automatically though?

src/gravity.rs Outdated Show resolved Hide resolved
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Aug 14, 2019

@federicomenaquintero Thanks, 👍 after cargo fmt

Gravity is an enum, and so it didn't get its functions auto-generated
by gir.

Fixes #156
@federicomenaquintero federicomenaquintero force-pushed the federicomenaquintero:master branch from c817ce0 to 436493b Aug 15, 2019
@federicomenaquintero

This comment has been minimized.

Copy link
Contributor Author

federicomenaquintero commented Aug 15, 2019

Just fixed the copyright date and ran cargo fmt. I'm not 100% sure if it's using the style you expect; I didn't see a .rustfmt.toml...

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 15, 2019

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 17, 2019

@GuillaumeGomez good to go

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 19, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit c58fe8f into gtk-rs:master Aug 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.