Added new types. #55

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Projects
None yet
3 participants
@RazrFalcon
Contributor

RazrFalcon commented Feb 25, 2017

Added new pango types:

  • Style
  • Variant
  • Weight
  • Stretch
  • LayoutIter
  • Gravity
  • GravityHint
  • Script
  • Direction
  • BidiType
  • FontMask
  • LayoutLine
  • EllipsizeMode
  • WrapMode

A new Rectangle implementation.

Reexported PANGO_SCALE constant.

Added new dependency: bitflags

+}
+
+#[doc(hidden)]
+impl ToGlib for Stretch {

This comment has been minimized.

@EPashkin

EPashkin Feb 25, 2017

Member

I don't see removing pub use ffi::PangoStretch as Stretch; from lib.rs for this and others.
And this line override pub use auto::* and generating will be unusable to enduser.
Can you generate all reexported and remove reexports?

@EPashkin

EPashkin Feb 25, 2017

Member

I don't see removing pub use ffi::PangoStretch as Stretch; from lib.rs for this and others.
And this line override pub use auto::* and generating will be unusable to enduser.
Can you generate all reexported and remove reexports?

This comment has been minimized.

@EPashkin

EPashkin Feb 25, 2017

Member

Sorry, I looked to wrong commit, you already remove reexport,
but, please, remove others too.

@EPashkin

EPashkin Feb 25, 2017

Member

Sorry, I looked to wrong commit, you already remove reexport,
but, please, remove others too.

This comment has been minimized.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

I hope it would be easy. I'vs relapsed only that types that I need.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

I hope it would be easy. I'vs relapsed only that types that I need.

This comment has been minimized.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

src/auto/rectangle.rs
+// DO NOT EDIT
+
+use ffi;
+use glib::translate::*;

This comment has been minimized.

@EPashkin

EPashkin Feb 25, 2017

Member

This file last from attempt to generate rectangle, remove it

@EPashkin

EPashkin Feb 25, 2017

Member

This file last from attempt to generate rectangle, remove it

This comment has been minimized.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

I can't prevent gir from generating it? Or I should just remove it from git and ignore it?

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

I can't prevent gir from generating it? Or I should just remove it from git and ignore it?

This comment has been minimized.

@EPashkin

EPashkin Feb 25, 2017

Member

You don't removed it after generate attempt, gir don't regenerate it now.

@EPashkin

EPashkin Feb 25, 2017

Member

You don't removed it after generate attempt, gir don't regenerate it now.

This comment has been minimized.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

}
-impl Rectangle for PangoRectangle {
- fn new(x: i32, y: i32, width: i32, height: i32) -> PangoRectangle {

This comment has been minimized.

@EPashkin

EPashkin Feb 25, 2017

Member

Restore this function in impl Rectangle { may be someone used it.

@EPashkin

EPashkin Feb 25, 2017

Member

Restore this function in impl Rectangle { may be someone used it.

This comment has been minimized.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Ok.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Ok.

This comment has been minimized.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 25, 2017

Member

Also better try generate more to uncomment almost all Layout and LayoutIter members.

Member

EPashkin commented Feb 25, 2017

Also better try generate more to uncomment almost all Layout and LayoutIter members.

@RazrFalcon

This comment has been minimized.

Show comment
Hide comment
@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

About warnings:

warning: unused import: `glib_ffi`, #[warn(unused_imports)] on by default
 --> src/auto/enums.rs:5:5
  |
5 | use glib_ffi;
  |     ^^^^^^^^

warning: unused import: `glib::error::ErrorDomain`, #[warn(unused_imports)] on by default
 --> src/auto/enums.rs:6:5
  |
6 | use glib::error::ErrorDomain;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^

Should I just comment this lines? Or remove them completely.

Contributor

RazrFalcon commented Feb 25, 2017

About warnings:

warning: unused import: `glib_ffi`, #[warn(unused_imports)] on by default
 --> src/auto/enums.rs:5:5
  |
5 | use glib_ffi;
  |     ^^^^^^^^

warning: unused import: `glib::error::ErrorDomain`, #[warn(unused_imports)] on by default
 --> src/auto/enums.rs:6:5
  |
6 | use glib::error::ErrorDomain;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^

Should I just comment this lines? Or remove them completely.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 25, 2017

Member

As it in generated code, currently you only can ignore it.

Member

EPashkin commented Feb 25, 2017

As it in generated code, currently you only can ignore it.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 25, 2017

Member

Seems good to me. Anything else remaining for you @EPashkin?

Member

GuillaumeGomez commented Feb 25, 2017

Seems good to me. Anything else remaining for you @EPashkin?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 25, 2017

Member

Generate
"Pango.LayoutLine",
"Pango.EllipsizeMode",
"Pango.WrapMode",

Member

EPashkin commented Feb 25, 2017

Generate
"Pango.LayoutLine",
"Pango.EllipsizeMode",
"Pango.WrapMode",

@RazrFalcon

This comment has been minimized.

Show comment
Hide comment
@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

Contributor

RazrFalcon commented Feb 25, 2017

Done.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 25, 2017

Member

Seems you forgot add auto/layout_line.rs

Member

EPashkin commented Feb 25, 2017

Seems you forgot add auto/layout_line.rs

@RazrFalcon

This comment has been minimized.

Show comment
Hide comment
@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

D'oh.

Contributor

RazrFalcon commented Feb 25, 2017

D'oh.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 25, 2017

Member

Thanks. 👍

Member

EPashkin commented Feb 25, 2017

Thanks. 👍

src/widgets/rectangle.rs
- PangoRectangle {
+impl Rectangle {
+ pub fn new(x: i32, y: i32, width: i32, height: i32) -> Rectangle {
+ Rectangle {
x: x as c_int,

This comment has been minimized.

@EPashkin

EPashkin Feb 25, 2017

Member

Hm, as c_int unneeded

@EPashkin

EPashkin Feb 25, 2017

Member

Hm, as c_int unneeded

This comment has been minimized.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

It's old code. Not mine.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

It's old code. Not mine.

This comment has been minimized.

@EPashkin

EPashkin Feb 25, 2017

Member

Old code created PangoRectangle with c_int fields, you add struct with i32 fields

@EPashkin

EPashkin Feb 25, 2017

Member

Old code created PangoRectangle with c_int fields, you add struct with i32 fields

This comment has been minimized.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

@RazrFalcon

RazrFalcon Feb 25, 2017

Contributor

Done.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 25, 2017

Member

Again 👍

Member

EPashkin commented Feb 25, 2017

Again 👍

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 25, 2017

Member

I restart CI but otherwise it's all good. Thanks!

Member

GuillaumeGomez commented Feb 25, 2017

I restart CI but otherwise it's all good. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 518dbc2 into gtk-rs:master Feb 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment