Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove versions from git dependencies and update bitflags #20

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
5 participants
@vhdirk
Copy link

vhdirk commented Jul 12, 2018

For this to work, these modifications are needed on other gtk-rs projects too (e.g. gtk). See #19

Cargo.toml Outdated
gobject-sys = { git = "https://github.com/gtk-rs/sys" }
pango-sys = { git = "https://github.com/gtk-rs/sys" }
cairo-sys-rs = { git = "https://github.com/gtk-rs/cairo" }
pangocairo-sys = { git = "https://github.com/gtk-rs/sys" }

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jul 12, 2018

Member

Please remove this empty line.

@vhdirk vhdirk force-pushed the vhdirk:dependencies branch from ce4dba5 to 273de0a Jul 12, 2018

@vhdirk vhdirk force-pushed the vhdirk:dependencies branch from 273de0a to 6052615 Jul 13, 2018

@vhdirk

This comment has been minimized.

Copy link
Author

vhdirk commented Jul 13, 2018

Rebased on master

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 13, 2018

@vhdirk We have crate branch for this

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 13, 2018

I'm still not sure what to do about this... Any opinion @sdroege?

@vhdirk

This comment has been minimized.

Copy link
Author

vhdirk commented Jul 13, 2018

The crate branch serves a different purpose. I'm building upon https://github.com/sdroege/gobject-subclass, which specifies it's dependencies differently.
Since you're using git anyway, is there any specific reason why you'd want to specify the exact version as well?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 13, 2018

I have to admit I never thought about it. Can't recall why we did it like this.

@vhdirk

This comment has been minimized.

Copy link
Author

vhdirk commented Jul 13, 2018

If there really is a reason for it, I would be totally fine with applying that in https://github.com/sdroege/gobject-subclass (end derivatives). Right now, the only reason I can think of would be to immediately pin down the major revision number for any next release. But that's just guessing.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 13, 2018

Maybe just send a PR and make it consistent with all the other gtk-rs repositories (i.e. remove the versions) :)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 13, 2018

Oh this is actually a PR. Looks good for me to merge, but I'll let @GuillaumeGomez and @EPashkin decide about the style (whether using single-line entries or the detailed ones as before just without version).

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 13, 2018

@vhdirk: I'd really prefer the solution proposed by @sdroege if you don't mind.

@vhdirk

This comment has been minimized.

Copy link
Author

vhdirk commented Jul 14, 2018

I don't mind at all. Just specify what you want it to look like and I'll create PRs to every project that it's needed for.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 14, 2018

Remove the dependencies version in the gstreamer repositories? I suppose the problem is coming from there no?

@vhdirk

This comment has been minimized.

Copy link
Author

vhdirk commented Jul 14, 2018

@GuillaumeGomez I'm not using the gstreamer repositories here at all.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 14, 2018

Euh yes, I meant gobject-subclass... Let's just merge then, I'll fix the release script later on. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 2df4565 into gtk-rs:master Jul 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.