Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boxing in async func #107

Merged
merged 1 commit into from Aug 19, 2019
Merged

Fix boxing in async func #107

merged 1 commit into from Aug 19, 2019

Conversation

@EPashkin
Copy link
Member

EPashkin commented Aug 10, 2019

@EPashkin EPashkin force-pushed the EPashkin:regen branch from 1ac7527 to 8d163a7 Aug 10, 2019
@EPashkin EPashkin force-pushed the EPashkin:regen branch from 8d163a7 to 88a2aac Aug 19, 2019
@EPashkin EPashkin force-pushed the EPashkin:regen branch from 88a2aac to 1015725 Aug 19, 2019
@EPashkin EPashkin changed the title WIP: Fix boxing in async func Fix boxing in async func Aug 19, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 19, 2019

Ready for review

@@ -34,8 +34,8 @@ v3_24 = ["v3_22", "gtk-source-sys/v3_24"]
default = ["v3_0"]
purge-lgpl-docs = ["gtk-rs-lgpl-docs", "gtk/purge-lgpl-docs"]
embed-lgpl-docs = ["gtk-rs-lgpl-docs", "gtk/embed-lgpl-docs"]
dox = ["gtk/dox", "gtk-source-sys/dox"]
futures = ["futures-preview", "fragile", "gio/futures"]

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Aug 19, 2019

Member

Good catch for this one!

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 19, 2019

👍

cc @sdroege

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 19, 2019

👍 @GuillaumeGomez all green also

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 19, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 65d106c into gtk-rs:master Aug 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin EPashkin deleted the EPashkin:regen branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.