Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to futures 0.3 #91

Merged
merged 4 commits into from Apr 27, 2019

Conversation

Projects
None yet
2 participants
@sdroege
Copy link
Member

commented Apr 26, 2019

No description provided.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

@GuillaumeGomez not sure what's wrong with travis here? I think the check is broken somehow, the submodule is in the right version and in sync with the code. Succeeded apart from that.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

You need to regen apparently? Check if submodule version matches the one in version.txt.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

You need to regen apparently? Check if submodule version matches the one in version.txt.

It does and that's exactly the version it should be :)

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Oh this is about -sys. Why does this also contain -sys in the same repo?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

No clue but it does. :3

@sdroege sdroege force-pushed the sdroege:futures-0.3 branch from 929e8a5 to 4b040a4 Apr 26, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Fixed and leaving for today :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Thanks! :)

@sdroege sdroege force-pushed the sdroege:futures-0.3 branch from 6cd0a25 to 89fc6c6 Apr 27, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

@GuillaumeGomez all green now

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 6b0bc18 into gtk-rs:master Apr 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.