Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions in Travis/AppVeyor configuration #130

Merged
merged 3 commits into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Feb 12, 2019

And also run tests with default features for all the crates.

.travis.yml Outdated
make regen_check;
fi
- for crate in "atk-sys gdk-pixbuf-sys gdk-sys gio-sys glib-sys gobject-sys gtk-sys pangocairo-sys pango-sys"; do
cd $crate && cargo test && cd ..

This comment has been minimized.

@EPashkin

EPashkin Feb 12, 2019

Member

Better don't do this now, it take too much time and fails.

This comment has been minimized.

@sdroege

sdroege Feb 12, 2019

Author Member

Ah so nobody actually fixed the test since they were merged... disappointing :( Then I disable that again.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 12, 2019

Your gir repo has changes "Generated by gir (https://github.com/gtk-rs/gir @ 4a198d9+)"

Update versions in Travis/AppVeyor configuration
And also run tests with default features for all the crates.

@sdroege sdroege force-pushed the sdroege:travis-xenial branch from ca74845 to d71023d Feb 12, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

Your gir repo has changes "Generated by gir (https://github.com/gtk-rs/gir @ 4a198d9+)"

What do you mean?

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

I see. I can't reproduce this here unfortunately. Where does that come from?

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

I mean, make regen_check finishes without any diff at the end here.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 12, 2019

Strange error, don't understand it reason, restarted job just in case

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 12, 2019

Found problem, new cargo add comment in lock file.
@sdroege please update gir to 27232165a279c49da2e740e3d3eee2b014ba5516

+++ b/Cargo.lock
@@ -1,3 +1,5 @@
+# This file is automatically @generated by Cargo.
+# It is not intended for manual editing.
 [[package]]
 name = "aho-corasick"

sdroege added some commits Feb 12, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

Done, thanks for finding the reason :)

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 13, 2019

@GuillaumeGomez all green

@GuillaumeGomez GuillaumeGomez merged commit a187c4b into gtk-rs:master Feb 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.