Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use disguised flag #137

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented May 11, 2019

Part of gtk-rs/gir#760

cc @GuillaumeGomez, @sdroege

We lose all Debug for disguised and test checks for "GdkAtom" and "GIConv"

@EPashkin EPashkin changed the title Use disguised flag WIP: Use disguised flag May 11, 2019

.finish()
}
}
pub type GBookmarkFile = *mut _GBookmarkFile;

This comment has been minimized.

Copy link
@sdroege

sdroege May 11, 2019

Member

Why this representation change?

This comment has been minimized.

Copy link
@EPashkin

EPashkin May 11, 2019

Author Member

This current representation for disguised types,
made for GdkAtom and GIConv

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez May 17, 2019

Member

Good for you @sdroege ?

This comment has been minimized.

Copy link
@sdroege

sdroege May 20, 2019

Member

Yes, was just curious if this was intentional and why.

@EPashkin EPashkin force-pushed the EPashkin:Use_disguised_flag branch from 18c6b2d to 3ac401c May 15, 2019

@EPashkin EPashkin changed the title WIP: Use disguised flag Use disguised flag May 15, 2019

@GuillaumeGomez GuillaumeGomez merged commit c45adc7 into gtk-rs:master May 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:Use_disguised_flag branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.