Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print some additional output on macOS if pkg-config fails #141

Merged
merged 2 commits into from Jun 21, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

commented Jun 20, 2019

homebrew is broken by design and requires manual user-intervention.
See Homebrew/homebrew-core#40179 for more
details.

Fixes gtk-rs/cairo#263

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Fine enough for me then, thanks!

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

So problem now is that build.rs is autogenerated. Should we add a special case to gir for this if the crate name is gobject-sys? @EPashkin ideas? :)

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

@sdroege IMHO adding this for ns.sys_crate_name=="gobject-sys" is good idea,
I will add it

@sdroege sdroege force-pushed the sdroege:homebrew-brokenness-workaround branch from 642994d to 43104fa Jun 20, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

@EPashkin Updated the PR. Thanks!

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

👍

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

@sdroege Thanks, 👍 after all version.txt updated

Print some additional output on macOS if pkg-config fails
homebrew is broken by design and requires manual user-intervention.
See Homebrew/homebrew-core#40179 for more
details.

Fixes gtk-rs/cairo#263

@sdroege sdroege force-pushed the sdroege:homebrew-brokenness-workaround branch from 43104fa to ae635cc Jun 21, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

Regenerated all the version.txt. Wanted to keep the churn lower but the CI does not like that :)

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

@GuillaumeGomez all green

@GuillaumeGomez GuillaumeGomez merged commit a5fbbde into gtk-rs:master Jun 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.