Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gtk4 files #145

Merged
merged 7 commits into from Jul 23, 2019
Merged

Add gtk4 files #145

merged 7 commits into from Jul 23, 2019

Conversation

@sfanxiang
Copy link
Member

sfanxiang commented Jul 15, 2019

Squashed from https://github.com/sfanxiang/gtk-rs-sys/commits/gtk4, due to large merge conflicts.

sfanxiang added 2 commits Jul 15, 2019
gsk4-sys/LICENSE Outdated Show resolved Hide resolved
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 15, 2019

Looks good to me. For the Travis CI, why does it depend on the example? Can't we build things without the GTK4 examples for now and once everything is in place enable the examples?

@sfanxiang

This comment has been minimized.

Copy link
Member Author

sfanxiang commented Jul 15, 2019

@sdroege Dropped gtk4 examples.

@alatiera

This comment has been minimized.

Copy link

alatiera commented Jul 15, 2019

Looks good to me as well.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 16, 2019

What has to be done for appveyor here? I see that it's green, but travis is not :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 16, 2019

Appveyor don't have regen check
IMHO this PR missed 3 thing:

  1. update rust to 1.36.0 in .travis.yml,
  2. update submodules
  3. full regen: old version.txt need changed too.
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 16, 2019

@sfanxiang Thanks

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 17, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 17, 2019

Let's get this in then, I'd say? :)

@sfanxiang sfanxiang changed the title WIP: Add gtk4 files Add gtk4 files Jul 20, 2019
@sfanxiang

This comment has been minimized.

Copy link
Member Author

sfanxiang commented Jul 23, 2019

Hi all, what's the status on this? Can we please merge this or is there anything I'm supposed to do?

Thanks for reviewing, by the way.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 23, 2019

Hi all, what's the status on this? Can we please merge this or is there anything I'm supposed to do?

I don't know, it was ready from my side 6 days ago already.

@GuillaumeGomez ?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jul 23, 2019

Arf sorry! Might have missed the notification (don't hesitate to ping us in such cases!)...

@GuillaumeGomez GuillaumeGomez merged commit 769d731 into gtk-rs:master Jul 23, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.