Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove graphene #149

Merged
merged 1 commit into from Aug 7, 2019
Merged

Remove graphene #149

merged 1 commit into from Aug 7, 2019

Conversation

@sfanxiang
Copy link
Member

sfanxiang commented Aug 6, 2019

graphene is now in its own repo.

cc @GuillaumeGomez @sdroege

graphene is now in its own repo.
@sfanxiang sfanxiang changed the title WIP: Remove graphene Remove graphene Aug 6, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 6, 2019

What do you mean with it being in its own repo? Wasn't the goal to have the -sys part here and the other part in gtk-rs/graphene?

@sfanxiang

This comment has been minimized.

Copy link
Member Author

sfanxiang commented Aug 6, 2019

@sdroege

@alatiera suggested moving graphene-sys to the graphene repo for easier maintenance, and @GuillaumeGomez agreed. graphene-sys now lives at https://github.com/gtk-rs/graphene/tree/master/graphene-sys.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 6, 2019

I didn't agree. I said it was an acceptable solution just like doing nothing and took sourceview as an example. You'll note that sourceview is the only "main" gtk-rs repository which owns its own sys part.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 6, 2019

You'll note that sourceview is the only "main" gtk-rs repository which owns its own sys part.

cairo too :)

I don't mind either way. Just keep it in the sys repo for the other 3 crates for consistency with the gtk3 versions.

@alatiera

This comment has been minimized.

Copy link

alatiera commented Aug 6, 2019

I am also fine either way, since its somewhat standalone module, I think its easier to have both crates in the same repo. Would be fine otherwise as well if the other way around is preferred.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 7, 2019

As that's how the gtk-rs/graphene repo is now, let's get this PR merged I guess!

@GuillaumeGomez GuillaumeGomez merged commit 6954dd6 into gtk-rs:master Aug 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.