Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tempfile in tests #154

Merged
merged 2 commits into from Nov 16, 2019
Merged

Use tempfile in tests #154

merged 2 commits into from Nov 16, 2019

Conversation

@EPashkin
Copy link
Member

EPashkin commented Nov 15, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 15, 2019

Thanks!

Merging once CI passed.

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 15, 2019

Build error seem related to gtk-rs/glib#534

error: expected `*` or `+`

   --> /home/travis/.cargo/git/checkouts/glib-928cf7b282977403/5613e42/src/clone.rs:170:24

    |

170 |     ($($(@ $weak:ident)? $variables:ident),+ => $(@default-return $return_value:expr,)? move || $body:block ) => (

    |                        ^

    |

    = note: `?` is not a macro repetition operator in the 2015 edition, but is accepted in the 2018 edition
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 15, 2019

I think it might be bound to the rust version. But in any case, I realized we didn't update the rust version in the tests so I opened #155

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 15, 2019

Restarted failed jobs

@EPashkin EPashkin force-pushed the EPashkin:tempfile branch from b3d040c to 19f6b7f Nov 15, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 15, 2019

Oops, forgot to update gtk4 etc.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 15, 2019

Oh indeed. Good luck updating them. ;)

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 15, 2019

Done

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 15, 2019

CI passed too

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 16, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 94a8fcf into gtk-rs:master Nov 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin EPashkin deleted the EPashkin:tempfile branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.