New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include LICENSE to sub-crates #74

Merged
merged 2 commits into from Jan 7, 2018

Conversation

Projects
None yet
3 participants
@ignatenkobrain
Contributor

ignatenkobrain commented Dec 3, 2017

Signed-off-by: Igor Gnatenko ignatenko@src.gnome.org

include LICENSE to sub-crates
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 3, 2017

It was symbolic link?
This don't work on Windows.

include LICENSE to sub-crates
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
@ignatenkobrain

This comment has been minimized.

Contributor

ignatenkobrain commented Dec 3, 2017

@EPashkin replaced with real copy.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 3, 2017

@ignatenkobrain Now it looks normal.
Any reason to do that without copying COPYRIGHT ?

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 3, 2017

As I understand source can't be published as separate parts.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Jan 7, 2018

@GuillaumeGomez, maybe we need merge this.
I still has no idea what to do with "COPYRIGHT" file, but including "LICENSE" in published packages is IMHO right way.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Jan 7, 2018

Completely missed it. Merging. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 1eb3c44 into gtk-rs:master Jan 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment