New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UInt flags #88

Merged
merged 3 commits into from Apr 3, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Apr 2, 2018

Make flags c_uint based to remove
Part of gtk-rs/gir#575

Also contains ABI test code without it usage.

It won't builds until all normal crates updated too.

cc @GuillaumeGomez, @sdroege, @tmiasko

@tmiasko

This comment has been minimized.

Show comment
Hide comment
@tmiasko

tmiasko Apr 2, 2018

Contributor

The sys crates looks fine. Nice that dependency on biflags is removed as well. Thanks!

Contributor

tmiasko commented Apr 2, 2018

The sys crates looks fine. Nice that dependency on biflags is removed as well. Thanks!

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 2, 2018

Member

Sounds really great! One less dependency always make me happy. :)

Member

GuillaumeGomez commented Apr 2, 2018

Sounds really great! One less dependency always make me happy. :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 3, 2018

Member

Its not one less, but one more actually, if we count tests 😉

Member

EPashkin commented Apr 3, 2018

Its not one less, but one more actually, if we count tests 😉

@EPashkin EPashkin changed the title from WIP: UInt flags to UInt flags Apr 3, 2018

@GuillaumeGomez GuillaumeGomez merged commit 28c6068 into gtk-rs:master Apr 3, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@EPashkin EPashkin deleted the EPashkin:uint_flags branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment