Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing headers for ABI checks. #90

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
3 participants
@tmiasko
Copy link
Contributor

tmiasko commented Apr 19, 2018

No description provided.

@tmiasko

This comment has been minimized.

Copy link
Contributor Author

tmiasko commented Dec 16, 2018

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 16, 2018

Seems good to me, thanks!

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 16, 2018

@tmiasko Thanks for remembering about this PR, 👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 16, 2018

I think we can ignore regen check now and merge, as we need update sys if gtk-rs/gir#675 accepted.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 16, 2018

I was about to comment about it. This PR doesn't impact it so let's ignore that. I'll just merge.

@GuillaumeGomez GuillaumeGomez merged commit dfd4caa into gtk-rs:master Dec 16, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@tmiasko tmiasko deleted the tmiasko:include-headers branch Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.