New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore clippy warnings and fix functions with arrays #96

Merged
merged 2 commits into from Jun 16, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Jun 16, 2018

EPashkin added some commits Jun 16, 2018

@@ -1589,7 +1590,7 @@ extern "C" {
pub fn g_object_get_qdata(object: *mut GObject, quark: glib::GQuark) -> gpointer;
//pub fn g_object_get_valist(object: *mut GObject, first_property_name: *const c_char, var_args: /*Unimplemented*/va_list);
#[cfg(any(feature = "v2_54", feature = "dox"))]
pub fn g_object_getv(object: *mut GObject, n_properties: c_uint, names: *mut c_char, values: GValue);
pub fn g_object_getv(object: *mut GObject, n_properties: c_uint, names: *mut *const c_char, values: *mut GValue);

This comment has been minimized.

@sdroege

sdroege Jun 16, 2018

Member

This changes quite a bit

New gir-files or what is causing this?

@sdroege

sdroege Jun 16, 2018

Member

This changes quite a bit

New gir-files or what is causing this?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jun 16, 2018

Member

I have concerns about this change as well.

@GuillaumeGomez

GuillaumeGomez Jun 16, 2018

Member

I have concerns about this change as well.

This comment has been minimized.

@EPashkin

EPashkin Jun 16, 2018

Member

Yes, it was added before in #93 as manual functions.

@EPashkin

EPashkin Jun 16, 2018

Member

Yes, it was added before in #93 as manual functions.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 16, 2018

Member

Looks good to me

Member

sdroege commented Jun 16, 2018

Looks good to me

@EPashkin EPashkin changed the title from Ignore clippy warnings to Ignore clippy warnings and fix functions with arrays Jun 16, 2018

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 16, 2018

Member

CI passed (with one bad on travis due futures)

Member

EPashkin commented Jun 16, 2018

CI passed (with one bad on travis due futures)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 16, 2018

Member

Then let's merge. Thanks!

Member

GuillaumeGomez commented Jun 16, 2018

Then let's merge. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit b76ccec into gtk-rs:master Jun 16, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:clippy_warnings branch Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment