Skip to content

Makefile: install-headers-peas installs .pc file to wrong path #181

Closed
Closed
Makefile: install-headers-peas installs .pc file to wrong path#181

Description

@dsboger-zz
dsboger-zz
opened on Jan 9, 2017

Based on other install-headers-*, the destination path should be $(DESTDIR)$(prefix)/$(libdir)/pkgconfig, but it is $(DESTDIR)$(datadir)/pkgconfig.

Excerpt from GNUmakefile:

install-headers-vte: vted-$(MAJOR).pc install-headers-gtkd
	(cd srcvte; echo $(SOURCES_VTED) | sed -e s,srcvte/,,g | xargs tar cf -) | (cd $(DESTDIR)$(prefix)/include/d/gtkd-$(MAJOR); tar xv)
	install -m 644 vted-$(MAJOR).pc $(DESTDIR)$(prefix)/$(libdir)/pkgconfig

install-headers-peas: peasd-$(MAJOR).pc install-headers-gtkd
	(cd srcpeas; echo $(SOURCES_PEASD) | sed -e s,srcpeas/,,g | xargs tar cf -) | (cd $(DESTDIR)$(prefix)/include/d/gtkd-$(MAJOR); tar xv)
install -m 644 peasd-$(MAJOR).pc $(DESTDIR)$(datadir)/pkgconfig

Activity

  1. MikeWey commented on Jan 9, 2017

    @MikeWey
    MikeWey
    on Jan 9, 2017
    Member

    I think they should all go in the datadir, as per issue #50.
    I seems that change was undone in pull #160.

    I think they should all be reverted to $(DESTDIR)$(datadir)/pkgconfig

  2. dsboger-zz commented on Jan 9, 2017

    @dsboger-zz
    dsboger-zz
    on Jan 9, 2017
    Author

    All other files are installed to the right places, but for peasd-3.pc it resolves like this:

    install -m 644 peasd-3.pc /home/build/pkg/gtkd//usr/share/pkgconfig
install: cannot create regular file '/home/build/pkg/gtkd//usr/share/pkgconfig': No such file or directory
  3. MikeWey
    added a commit that references this issue on Jan 9, 2017

    Set the correct path for the pkgconfig files. #181

    7ccbaab

  4. MikeWey commented on Jan 9, 2017

    @MikeWey
    MikeWey
    on Jan 9, 2017
    Member

    That is probably because the makefile didn't create the destination directory.

    bioinfornatics is the packager for Fedora and he made the case for $datadir/pkgconfig.
    And pkgconfig does search for the files in /usr[/local]/share.

    I've reverted the change in paths from #160, so it should be working now.

  5. dsboger-zz commented on Jan 9, 2017

    @dsboger-zz
    dsboger-zz
    on Jan 9, 2017
    Author

    It is working now, thanks! Would it be possible to release this fix?

  6. dsboger-zz
    closed this as completedon Jan 9, 2017

  7. MikeWey commented on Jan 10, 2017

    @MikeWey
    MikeWey
    on Jan 10, 2017
    Member

    3.5.1 tagged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions