Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: install-headers-peas installs .pc file to wrong path #181

Closed
dsboger opened this issue Jan 9, 2017 · 5 comments
Closed

Makefile: install-headers-peas installs .pc file to wrong path #181

dsboger opened this issue Jan 9, 2017 · 5 comments

Comments

@dsboger
Copy link

@dsboger dsboger commented Jan 9, 2017

Based on other install-headers-*, the destination path should be $(DESTDIR)$(prefix)/$(libdir)/pkgconfig, but it is $(DESTDIR)$(datadir)/pkgconfig.

Excerpt from GNUmakefile:

install-headers-vte: vted-$(MAJOR).pc install-headers-gtkd
	(cd srcvte; echo $(SOURCES_VTED) | sed -e s,srcvte/,,g | xargs tar cf -) | (cd $(DESTDIR)$(prefix)/include/d/gtkd-$(MAJOR); tar xv)
	install -m 644 vted-$(MAJOR).pc $(DESTDIR)$(prefix)/$(libdir)/pkgconfig

install-headers-peas: peasd-$(MAJOR).pc install-headers-gtkd
	(cd srcpeas; echo $(SOURCES_PEASD) | sed -e s,srcpeas/,,g | xargs tar cf -) | (cd $(DESTDIR)$(prefix)/include/d/gtkd-$(MAJOR); tar xv)
install -m 644 peasd-$(MAJOR).pc $(DESTDIR)$(datadir)/pkgconfig
@MikeWey
Copy link
Member

@MikeWey MikeWey commented Jan 9, 2017

I think they should all go in the datadir, as per issue #50.
I seems that change was undone in pull #160.

I think they should all be reverted to $(DESTDIR)$(datadir)/pkgconfig

@dsboger
Copy link
Author

@dsboger dsboger commented Jan 9, 2017

All other files are installed to the right places, but for peasd-3.pc it resolves like this:

install -m 644 peasd-3.pc /home/build/pkg/gtkd//usr/share/pkgconfig
install: cannot create regular file '/home/build/pkg/gtkd//usr/share/pkgconfig': No such file or directory
@MikeWey
Copy link
Member

@MikeWey MikeWey commented Jan 9, 2017

That is probably because the makefile didn't create the destination directory.

bioinfornatics is the packager for Fedora and he made the case for $datadir/pkgconfig.
And pkgconfig does search for the files in /usr[/local]/share.

I've reverted the change in paths from #160, so it should be working now.

@dsboger
Copy link
Author

@dsboger dsboger commented Jan 9, 2017

It is working now, thanks! Would it be possible to release this fix?

@MikeWey
Copy link
Member

@MikeWey MikeWey commented Jan 10, 2017

3.5.1 tagged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants