New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add librsvg-2 #193

Merged
merged 2 commits into from Apr 3, 2017

Conversation

Projects
None yet
2 participants
@deviator
Contributor

deviator commented Apr 3, 2017

No description provided.

@deviator

This comment has been minimized.

Contributor

deviator commented Apr 3, 2017

fix #192

@deviator

This comment has been minimized.

Contributor

deviator commented Apr 3, 2017

ping @MikeWey
Have I done everything right? Autogenerated files needs to add for windows users? Because they have no gir files and they can't run wrapper, right?

@MikeWey

The updated version of generated/gtkd/gtkc/paths.d is missing.

The updated version of src/APILookup.txt is missing, or you need to add lookup: APILookupRsvg.txt so Rsvg is included when the generator runs.

addAliases: end
struct: Handle
class: Handle

This comment has been minimized.

@MikeWey

MikeWey Apr 3, 2017

Member

These two lines (34, 35) are not needed.

@MikeWey

This comment has been minimized.

Member

MikeWey commented Apr 3, 2017

Autogenerated files needs to add for windows users? Because they have no gir files and they can't run wrapper, right?

Yes, for now the generated code needs to be included. Getting things to a point where it isn't needed is a work in progress.

@MikeWey

MikeWey approved these changes Apr 3, 2017

@MikeWey MikeWey merged commit 94fab62 into gtkd-developers:master Apr 3, 2017

@deviator

This comment has been minimized.

Contributor

deviator commented Apr 3, 2017

The updated version of generated/gtkd/gtkc/paths.d is missing.

On this version it at gtkd/gtkd path. And I have some question about generation: some functions was not found (in other APILookup files), I remove they for working wrapper, and before some classes was not complete (some structs are not defined, functions body are missing). It's normal? Can this be due to mismatch of gtk versions on my and your systems?

deviator added a commit to deviator/GtkD that referenced this pull request Apr 3, 2017

@MikeWey

This comment has been minimized.

Member

MikeWey commented Apr 4, 2017

You probably have an older version of Gtk+ installed on your system. The generator currently doesn't handle that al that well, which is one of the reasons the generated source is in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment