Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSV and Scorecard certifier to new ontology and add unit tests #634

Merged
merged 6 commits into from
Mar 27, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Mar 26, 2023

  • update root_package and source query to use graphql
  • add unit tests for root_package and source query
  • update unit test for OSV certifier
  • add PkgToPurl helper function with unit tests
  • Change certifier commands to use graphql client
  • make client functions public
  • how to handle OSV that is not CVE or GHSA?
cve, ghsa, err := helpers.OSVToGHSACVE(id.VulnerabilityId)

as this currently returns an error. Changed to be a log and not create the isVulnerability

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - let's add a TODO with an issue for that conversion in the line around purl conversion.

Signed-off-by: pxp928 <parth.psu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants