Lu Guanqun guanqun

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

Naming is hard. ;D

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

Nice catch! Rather reasonable!

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

Yep! Will fix it.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

Right... The named arguments with overloaded function is still missing.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

OK.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

Thank you. I'll move it into checkTypeRequirements(). The reason of another round check is: if the overloaded function is not used, there's nowhere…

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

Good catch! This piece of code doesn't smell well... Another approach I'm thinking about is I don't create a new FunctionIdentifier node, just use …

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

Assigning a function identifier to a local variable and then call it with overloaded function doesn't work in this pull request. However, if this f…

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

I have one but forgot to cherry-pick into this branch, will add it.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

I'm using a std::set here, so no .front() method. It's a bit awkward to use .begin() and the dereference it.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

The main change is to use a set of Declarations in DeclarationContainer.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

I believe this is valid as during parsing we can't determine the types.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

making it NO_THROW right now.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

Here's what I'm asking for advice. I'm making it NO_THROW right now.

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

oops, will change this format...

guanqun commented on pull request ethereum/cpp-ethereum#1162
Lu Guanqun

This line is added by accident, will remove this...

guanqun opened pull request ethereum/cpp-ethereum#1162
Lu Guanqun
implement overloaded funciton
1 commit with 413 additions and 56 deletions
Lu Guanqun
  • Lu Guanqun 149267c
    implement overloaded function
guanqun opened pull request ethereum/cpp-ethereum#1024
Lu Guanqun
spot a simple typo when reading coding standards
1 commit with 1 addition and 1 deletion
Lu Guanqun
  • Lu Guanqun be383da
    spot a simple typo when reading coding standards
guanqun deleted branch add-exp at guanqun/cpp-ethereum
guanqun commented on pull request ethereum/cpp-ethereum#978
Lu Guanqun

Hi @chriseth, there's no pow function for both big_int and big_int in boost::multiprecision. So I resort to this approach, which is to check whethe…