Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix bug in module name #5

Merged
merged 1 commit into from May 10, 2013

Conversation

Projects
None yet
4 participants
@ghost

ghost commented May 2, 2013

Fixes this bug: guard-annotate-1.1.0/lib/guard/annotate.rb:44:in `class:Annotate': uninitialized constant Guard::Annotate::VERSION (NameError)

@joelparkerhenderson joelparkerhenderson Fix bug in module name: change from "AnnotateVersion" to "Annotate"
Fixes this bug: guard-annotate-1.1.0/lib/guard/annotate.rb:44:in `<class:Annotate>': uninitialized constant Guard::Annotate::VERSION (NameError)
6f26567
Owner

rymai commented May 2, 2013

Hi,

Thanks but I think the right fix is to use Guard::VERSION in https://github.com/guard/guard-annotate/blob/master/lib/guard/annotate.rb#L44 since the check is against Guard's version itself.

@ghost

ghost commented May 10, 2013

@rymai your solution does solve that bug. I believe the merge is still good to do, because it fixes the additional bug of the module name. For example, a class constant would typically be named like Foo::Bar::VERSION and not Foo::BarVersion::VERSION

@cpjolicoeur cpjolicoeur added a commit that referenced this pull request May 10, 2013

@cpjolicoeur cpjolicoeur Merge pull request #5 from SixArm/master
Fix bug in module name
1669011

@cpjolicoeur cpjolicoeur merged commit 1669011 into guard:master May 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment