Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added --server explanation #121

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Updated the docs with a few lines for people setting up guard-jasmine with the jasmine gem. More info in netzpirat#120

Contributor

eventualbuddha commented Apr 3, 2013

Seems good to me. What happens right now when you forget this option? Is there something we can do to point you in the right direction in that case?

If you see the linked issue, that's what I'm getting:

app error: No route matches [GET] "/jasmine" (ActionController::RoutingError)

I'm not sure what could be done other than adding it to the docs. What confuses me is: What does it mean if I specify another server instead of jasmine_gem? Do I need to run that server myself? All in all the different server options don't make much sense to me.

Contributor

netzpirat commented Apr 3, 2013

Thanks a lot for this, but I think we can do better by fixing the real problem: The server auto-detection happens after we set a default Jasmine URL, which differs depending on the server. By moving the server detection right before the default Jasmine URL generation in the Guard plugin class and also the CLI class, we should fix #120

That sounds awesome!

@netzpirat netzpirat closed this in 017813a Apr 3, 2013

Contributor

netzpirat commented Apr 3, 2013

Can you please try the master branch without specify the :server nor the :jasmine_url options? They should now have proper default values.

Wow, that's an amazing fast response. Thanks so much. Unfortunately, I updated from master, and it's still calling /jasmine. I'm pretty sure it's running with the latest code:

gem 'guard-jasmine', :git => "git://github.com/netzpirat/guard-jasmine.git"
vagrant@lucid64:/vagrant$ bundle update guard-jasmine
Updating git://github.com/netzpirat/guard-jasmine.git
Fetching gem metadata from https://rubygems.org/.......
Fetching gem metadata from https://rubygems.org/..
Resolving dependencies...
...
vagrant@lucid64:/vagrant$ guard-jasmine --verbose
01:30:12 - INFO - Guard::Jasmine starts Unicorn spec server on port 58925 in test environment (coverage off).
I, [2013-04-04T01:30:12.743506 #14395]  INFO -- : listening on addr=0.0.0.0:58925 fd=7
I, [2013-04-04T01:30:12.743668 #14395]  INFO -- : worker=0 spawning...
I, [2013-04-04T01:30:12.744902 #14395]  INFO -- : master process ready
I, [2013-04-04T01:30:12.745411 #14400]  INFO -- : worker=0 spawned pid=14400
I, [2013-04-04T01:30:12.745638 #14400]  INFO -- : Refreshing Gem list
01:30:12 - INFO - Waiting for Jasmine test runner at http://localhost:58925/jasmine
Contributor

netzpirat commented Apr 4, 2013

Thanks a lot for trying it. I see two more issues I need to fix: First the spec dir needs also to be auto detected, since the server detection depends on the spec dir, and I see a bad option detection in the CLI options, namely the url is still before the server detection. I fix that asap, but I'm short on time today, but you can expect an update tomorrow.

Great. Thanks so much. I'm not in a hurry, since it has an easy fix. Thanks for being so responsive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment