Report javascript errors that prevent specs from running. #123

merged 1 commit into from Apr 6, 2013


None yet
2 participants

swistak commented Apr 6, 2013

This solution is a bit hackish. But allows us to forward console output
and errors from javascript to test runner.

There can be multiple errors, and each of them will get reported.

Also specs will be marked as failed which gives correct error status for CI


swistak commented Apr 6, 2013

I've reworked solution to be completelly on side of javascript. Does not break tests anymore. But only reports one error.


swistak commented Apr 6, 2013

Travis reports build as failed becouse it failed on rbx in 1.9 mode (dunno why, but master also fails). Other platforms passed.

@netzpirat netzpirat merged commit e431dcc into guard:master Apr 6, 2013

1 check failed

default The Travis build failed

netzpirat commented Apr 6, 2013

This is great! Thanks a lot. I know that there are currently some problems with Rubinius, but I'm unsure what the problem is and I can't even install Rubinius on my local machine to investigate at the moment. Hope I can fix it next week and release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment