Prevent tests running multiple times #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a file triggers run_on_modifications which runs the tests. It is therefore unnecessary to run the tests from run_on_additions.
rymai
added a commit
that referenced
this pull request
Jan 6, 2014
…times Prevent tests running multiple times
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving files with Vim on linux, tests are being run twice.
As seen in several Guard plugins,
run_on_changesis running multiple times when saving files with Vim. This can be easily remedied by usingrun_on_modificationsinstead.See:
guard/guard#297
guard/guard#495
The
run_on_additionsmethod is also being called when saving files with Vim, causing multiple invocations of the test(s). Becauserun_on_modificationsis executed when a new file is created anyway, it should be unnecessary to run the tests explicitly fromrun_on_additions.