zeus support with :zeus => true option #129

Merged
merged 3 commits into from Oct 7, 2012

Projects

None yet

7 participants

@dpickett
Contributor

No description provided.

@thibaudgg thibaudgg and 1 other commented on an outdated diff Sep 28, 2012
lib/guard/rspec/runner.rb
@@ -193,6 +195,10 @@ def binstubs?
end
end
+ def zeus?
+ @zeus = @options[:zeus].nil? ? false : @options[:zeus]
thibaudgg
thibaudgg Sep 28, 2012 Owner
def zeus?
 @options[:zeus] || false
end

seems simpler no?

dpickett
dpickett Sep 28, 2012 Contributor

fixed

@thibaudgg thibaudgg and 1 other commented on an outdated diff Sep 28, 2012
lib/guard/rspec/runner.rb
@@ -193,6 +195,10 @@ def binstubs?
end
end
+ def zeus?
+ @zeus = @options[:zeus] || false
thibaudgg
thibaudgg Sep 28, 2012 Owner

Thanks, but @zeus = is still useless.

dpickett
dpickett Sep 28, 2012 Contributor

fixed

xhh commented Sep 29, 2012

👍 was planning to do the same thing ;)

xhh commented Sep 29, 2012

@dpickett I got a problem that the notification no longer pop-up after using the zeus-support branch of your repo (I'm using terminal-notifier-guard with guard), but it works without your changes for zeus support. Do you also have the same problem?

Owner

@xhh good question, maybe it's more a problem on Zeus side no?

xhh commented Sep 29, 2012

@thibaudgg at first I also thought that maybe Zeus was not passing the formatter argument correctly, but "zeus rspec spec/models/user_spec.rb -f html" works. I'm not sure if this can prove that it's not Zeus' problem, need to dig deeper.

Owner

Guard::RSpec::Formatter also need to be required with -r argument. Maybe it comes from there.

Narnach commented Oct 3, 2012

It works for me as well. Has anyone taken a stab at getting the zeus auto-start from guard-zeus integrated with this? guard-zeus + rspec did not quite work for me, but that was the one feature from there that I miss in this implementation.

jnv commented Oct 3, 2012

@Narnach It seems to me that guard-zeus mostly duplicates guard-rspec's functionality, it just runs the zeus server too. There's also the just-released guard-zeus-client which seems to do the same – without running the server.

Soo… guard-zeus-server anyone?

ryansch commented Oct 4, 2012

I didn't see a clean way to allow zeus server to print its output out every second without spamming my test runs in guard. That was the genesis for guard-zeus-client. If somebody can come up with a good way to start zeus via guard and still see the output in a non-intrusive way then I'll happily sunset my gem.

Contributor
dpickett commented Oct 7, 2012

yeah I intentionally did not include starting zeus due to it's unique output. Assuming that it's open in a separate process is fine for me, but we could add some checking/output around its state.

Contributor
dpickett commented Oct 7, 2012

@thibaudgg happy to provide what you need to merge this in - please let me know what you think is holding us back from that.

@thibaudgg thibaudgg merged commit 2d086d8 into guard:master Oct 7, 2012

1 check passed

default The Travis build passed
Details
Owner

Nothing, version 2.1.0 released! Thanks!

@thibaudgg thibaudgg referenced this pull request Oct 7, 2012
Closed

Zeus support #127

@romanbsd romanbsd commented on the diff Oct 8, 2012
lib/guard/rspec/runner.rb
@@ -98,6 +99,7 @@ def rspec_command(paths, options)
cmd_parts = []
cmd_parts << "rvm #{@options[:rvm].join(',')} exec" if @options[:rvm].respond_to?(:join)
cmd_parts << "bundle exec" if bundle_exec?
+ cmd_parts << 'zeus' if zeus?
romanbsd
romanbsd Oct 8, 2012

It's actually better to run zeus outside of bundler. I quote from zeus README:
"Q: "I should put it in my Gemfile, right? A: You can, but running bundle exec zeus instead of zeus can add precious seconds to a command that otherwise would be quite a bit faster. Zeus was built to be run from outside of bundler."

dpickett
dpickett Oct 8, 2012 Contributor

right - I circumvent bundle exec by setting the bundler option to false in my guard configuration block for rspec.

romanbsd
romanbsd Oct 8, 2012

Maybe the :zeus => true should set the :bundler to false?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment