Patch for Rinda::RingFinger.primary #91

Merged
merged 1 commit into from Oct 28, 2012

2 participants

@jarmo

Patch for Rinda::RingFinger.primary hanging forever on Ruby 1.9.2 & 1.9.3 from http://www.ruby-forum.com/topic/4229908

Without this patch i'm seeing the symptoms of Rinda::RingFinger.primary blocking forever.

@thibaudgg thibaudgg commented on the diff Oct 28, 2012
lib/guard/spork/spork_instance.rb
@@ -117,7 +117,7 @@ def running_on_windows?
Rinda::RingFinger.class_variable_set :@@finger, nil
ts = Rinda::RingFinger.primary
ts.read_all([:name, :MagazineSlave, nil, nil]).size > 0
- rescue DRb::DRbConnError
@thibaudgg
Guard member

Is te related to that Rinda::RingFinger bug?

@jarmo
jarmo added a note Oct 28, 2012

Yes, it is related with rinda_ring_finger_patch.rb:18 - unfortunately it will raise a RuntimeError and nothing more specific.

@thibaudgg
Guard member

Ok Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@thibaudgg thibaudgg merged commit 384c7ae into guard:master Oct 28, 2012

1 check passed

Details default The Travis build passed
@jarmo

Unfortunately this patch has to be at Spork side too to have full effect :( It seems to me though that Spork maintainer is not active at this moment.

All of this patch and other Rinda::RingFinger specific code can be removed when sporkrb/spork#217 and sporkrb/spork#214 have been merged. But as i said, Spork maintainer seems to be inactive.

@thibaudgg
Guard member

Ok, as long as it works as well for other users, I see no problem to keep it that way in the guard-spork side.
@nixme and @timcharper can you merge theses PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment