Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cool color output interferes with Pry #18

Closed
e2 opened this issue Dec 22, 2014 · 3 comments
Closed

Cool color output interferes with Pry #18

e2 opened this issue Dec 22, 2014 · 3 comments
Assignees

Comments

@e2
Copy link

e2 commented Dec 22, 2014

It updates on top of the Pry console in Guard.

The workaround:

guard 'zeus', cli: '> /dev/null' do

I'm wondering if there's a better way than just mentioning this in the README.

@qnm
Copy link
Member

qnm commented Dec 22, 2014

Hi @e2

You should probably expose it as a specific option, perhaps pry_workaround: true or similar?

You should be able to hook in around

def zeus_serve_options
.

What do you think?

@e2
Copy link
Author

e2 commented Dec 23, 2014

Actually my second message was supposed to be an issue in Zeus - but I got confused.

Anyway, this should be fixed in Zeus - the problem with '/dev/null' trick is that it silences errors (I'm not sure it even actually works!).

I considered logging as well. As another idea, I was wondering about capturing the Zeus output continuously, filtering it ("uncolorize") and every time a guard plugin action is triggered, it would dump the captured output.

On the other hand - I think Guard should actually be doing this. Guard could just support long-running processes internally, capture the output and dump it before and after every task.

I'm just thinking out loud here, because even if zeus would be fixed, some plugins need e.g. web servers running - and it would be nice to control their output from Guard as well.

It also seems too much work, since it's only a UI bug and doesn't prevent actually doing anything (while there is lots more important and urgent stuff to fix). That's why I thought about the README.

@qnm qnm self-assigned this Jan 13, 2015
@qnm qnm closed this as completed in 11d3f06 Jan 13, 2015
qnm added a commit that referenced this issue Jan 13, 2015
Add pry workaround note to the README [Fixes #18]
@qnm qnm removed the in progress label Jan 13, 2015
@luizcarvalho
Copy link

Great! This solve my problem! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants