New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification icons no longer displayed with Growl 1.3.3 using GNTP on OSX #231

Closed
idyll opened this Issue Jan 27, 2012 · 20 comments

Comments

Projects
None yet
7 participants
@idyll

idyll commented Jan 27, 2012

When using GNTP and the Growl 1.3.3 icons are no longer displayed on OSX. Instead Growl logs the following:

1/27/12 12:00:26.081 AM Growl: Not downloading icon for notification success of application Guard

It appears to be related to GNTP and the Growl 1.3.3 - images still work using growl/growl-notify and previous versions of Growl don't exhibit this behavior.

I am pretty sure this is a bug with Growl, but until it is fixed it should be noted somewhere.

@netzpirat

This comment has been minimized.

Show comment
Hide comment
@netzpirat

netzpirat Jan 27, 2012

Contributor

Thanks for reporting. I've asked the Growl guys and I'm waiting for a response. I'll update the status here when I have new information about it.

Contributor

netzpirat commented Jan 27, 2012

Thanks for reporting. I've asked the Growl guys and I'm waiting for a response. I'll update the status here when I have new information about it.

@netzpirat

This comment has been minimized.

Show comment
Hide comment
@netzpirat

netzpirat Jan 27, 2012

Contributor

GrowlMac confirmed that they know the issue and it'll be fixed with Growl 1.4.

Contributor

netzpirat commented Jan 27, 2012

GrowlMac confirmed that they know the issue and it'll be fixed with Growl 1.4.

@idyll

This comment has been minimized.

Show comment
Hide comment
@idyll

idyll Jan 29, 2012

It actually works on Growl 1.3.2 so I'd suggest not upgrading until 1.4 is released.

idyll commented Jan 29, 2012

It actually works on Growl 1.3.2 so I'd suggest not upgrading until 1.4 is released.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 1, 2012

Any way to revert Growl to 1.3.2? Hate this new icon lol

ghost commented Feb 1, 2012

Any way to revert Growl to 1.3.2? Hate this new icon lol

@idyll

This comment has been minimized.

Show comment
Hide comment
@idyll

idyll Feb 2, 2012

If you're lucky enough to have not installed it on your other computer, you can just copy the old file across. If not - Time Machine.

idyll commented Feb 2, 2012

If you're lucky enough to have not installed it on your other computer, you can just copy the old file across. If not - Time Machine.

@steakknife

This comment has been minimized.

Show comment
Hide comment
@steakknife

steakknife Feb 25, 2012

Contributor

Update: "Anyhow, it should be fixed in 1.4. If not in 1.4, then 2.0."

Contributor

steakknife commented Feb 25, 2012

Update: "Anyhow, it should be fixed in 1.4. If not in 1.4, then 2.0."

@thibaudgg

This comment has been minimized.

Show comment
Hide comment
@thibaudgg

thibaudgg Feb 25, 2012

Member

Too bad :(

Member

thibaudgg commented Feb 25, 2012

Too bad :(

@ChrisForsythe

This comment has been minimized.

Show comment
Hide comment
@ChrisForsythe

ChrisForsythe Feb 25, 2012

The reason for the change is that this specific item was causing 100% CPU for a lot of people. The tradeoff was worth it in our opinion so that people wouldn't run into that.

ChrisForsythe commented Feb 25, 2012

The reason for the change is that this specific item was causing 100% CPU for a lot of people. The tradeoff was worth it in our opinion so that people wouldn't run into that.

@idyll

This comment has been minimized.

Show comment
Hide comment
@idyll

idyll Feb 26, 2012

Respectfully, I don't agree. The primary reason I use Growl is so that I see a big green light when my tests pass and a big red light when my tests fail.

And my brain is trained to look for the colors. I honestly felt confused until I dug out my laptop and grabbed the older binary off it.

idyll commented Feb 26, 2012

Respectfully, I don't agree. The primary reason I use Growl is so that I see a big green light when my tests pass and a big red light when my tests fail.

And my brain is trained to look for the colors. I honestly felt confused until I dug out my laptop and grabbed the older binary off it.

@ttilley

This comment has been minimized.

Show comment
Hide comment
@ttilley

ttilley Feb 26, 2012

Member

it's only URL icons that have this problem. you may still send notifications to growl using files, and this is supported by the ruby_gntp library as far as i can tell. it's surprisingly useful despite being untouched in two years (as in, GNTP in growl for mac came after development on ruby_gntp halted).

Member

ttilley commented Feb 26, 2012

it's only URL icons that have this problem. you may still send notifications to growl using files, and this is supported by the ruby_gntp library as far as i can tell. it's surprisingly useful despite being untouched in two years (as in, GNTP in growl for mac came after development on ruby_gntp halted).

@ttilley

This comment has been minimized.

Show comment
Hide comment
@ttilley

ttilley Feb 26, 2012

Member

also, 1.4 is currently in its second beta so you hopefully won't have long to wait for it.

EDIT: 1.4b2 doesn't fix this issue, so it will likely not be fixed in 1.4.

Member

ttilley commented Feb 26, 2012

also, 1.4 is currently in its second beta so you hopefully won't have long to wait for it.

EDIT: 1.4b2 doesn't fix this issue, so it will likely not be fixed in 1.4.

@ChrisForsythe

This comment has been minimized.

Show comment
Hide comment
@ChrisForsythe

ChrisForsythe Feb 26, 2012

Ya, 1.4 doesn't fix this. 2.0 will. 1.3.2 has it, but if you have it and you hit 100% CPU, that's not cool at all.

ChrisForsythe commented Feb 26, 2012

Ya, 1.4 doesn't fix this. 2.0 will. 1.3.2 has it, but if you have it and you hit 100% CPU, that's not cool at all.

@SFEley

This comment has been minimized.

Show comment
Hide comment
@SFEley

SFEley Jun 14, 2012

I've just installed Growl 1.4 from the Mac app store and can confirm that this issue is still present. Rather frustrating to have a regression persisting for so long.

SFEley commented Jun 14, 2012

I've just installed Growl 1.4 from the Mac app store and can confirm that this issue is still present. Rather frustrating to have a regression persisting for so long.

@thibaudgg

This comment has been minimized.

Show comment
Hide comment
@thibaudgg

thibaudgg Jun 15, 2012

Member

Yeah, too bad... looking forward to use the new Notification Center of OS X Mountain Lion :)

Member

thibaudgg commented Jun 15, 2012

Yeah, too bad... looking forward to use the new Notification Center of OS X Mountain Lion :)

jgrocho added a commit to jgrocho/guard that referenced this issue Jul 16, 2012

Remove file:// prefix from image path for GNTP
ruby_gtnp supports embedding image data directly in the notification
allowing remote notifications to display an image.

In practice, this change has been tested with Growl for Windows
receiving the notification and it behaves as expected, i.e. the image
appears in the notification.

This also likely resolves issue #231, as that involves Growl (for OSX)
refusing to download the images.
@idyll

This comment has been minimized.

Show comment
Hide comment
@idyll

idyll Aug 15, 2012

I think at this point I think it is safe to look at closing this as the 1.3.1 release supports TerminalNotifier which is a much better solution than Growl at this point.

idyll commented Aug 15, 2012

I think at this point I think it is safe to look at closing this as the 1.3.1 release supports TerminalNotifier which is a much better solution than Growl at this point.

@netzpirat

This comment has been minimized.

Show comment
Hide comment
@netzpirat

netzpirat Aug 15, 2012

Contributor

Great to hear that TerminalNotifier works great and replaces Growl for you, but it isn't a replacement for Growl by no means. Growl works cross-plattform and even cross-machine, so it's for example a great way to have notifications from your Vagrant box shown on the Vagrant host. Also customizing the notifications is a great feature of Growl, I for example like to have the 'Music Video' display style for Guard, so that notifications are obtrusive and can't be missed.

We'll keep the Growl notifier in the future and continue to maintain it, so I prefer to keep this issue open as reminder for people using Growl and come to Guard issues because of the missing icons.

Contributor

netzpirat commented Aug 15, 2012

Great to hear that TerminalNotifier works great and replaces Growl for you, but it isn't a replacement for Growl by no means. Growl works cross-plattform and even cross-machine, so it's for example a great way to have notifications from your Vagrant box shown on the Vagrant host. Also customizing the notifications is a great feature of Growl, I for example like to have the 'Music Video' display style for Guard, so that notifications are obtrusive and can't be missed.

We'll keep the Growl notifier in the future and continue to maintain it, so I prefer to keep this issue open as reminder for people using Growl and come to Guard issues because of the missing icons.

@idyll

This comment has been minimized.

Show comment
Hide comment
@idyll

idyll Aug 15, 2012

Makes sense. At this point though I am starting to doubt this will ever be resolved in Growl for OS X.

The issue has been open for 7 months now and I am fairly confident that the upcoming Growl 2.0 release doesn't resolve this issue. Even with the fix for #304.

It would be great if this was to get fixed but I've given up hope on it.

idyll commented Aug 15, 2012

Makes sense. At this point though I am starting to doubt this will ever be resolved in Growl for OS X.

The issue has been open for 7 months now and I am fairly confident that the upcoming Growl 2.0 release doesn't resolve this issue. Even with the fix for #304.

It would be great if this was to get fixed but I've given up hope on it.

@netzpirat

This comment has been minimized.

Show comment
Hide comment
@netzpirat

netzpirat Aug 15, 2012

Contributor

This issue only affects users that use cross-machine notifications through the network protocol GNTP. For local notifications, the growl gem works just fine and I guess this is the majority of the users.

Contributor

netzpirat commented Aug 15, 2012

This issue only affects users that use cross-machine notifications through the network protocol GNTP. For local notifications, the growl gem works just fine and I guess this is the majority of the users.

@SFEley

This comment has been minimized.

Show comment
Hide comment
@SFEley

SFEley Aug 15, 2012

So you don't believe in distributed test running?

Seems like everybody wants this issue closed because they're convinced that the way they use Guard is the way everyone else uses it too.

On Aug 15, 2012, at 4:36 AM, Michael Kessler notifications@github.com wrote:

This issue only affects users that use cross-machine notifications through the network protocol GNTP. For local notifications, the growl gem works just fine and I guess this is the majority of the users.


Reply to this email directly or view it on GitHub.

SFEley commented Aug 15, 2012

So you don't believe in distributed test running?

Seems like everybody wants this issue closed because they're convinced that the way they use Guard is the way everyone else uses it too.

On Aug 15, 2012, at 4:36 AM, Michael Kessler notifications@github.com wrote:

This issue only affects users that use cross-machine notifications through the network protocol GNTP. For local notifications, the growl gem works just fine and I guess this is the majority of the users.


Reply to this email directly or view it on GitHub.

@netzpirat

This comment has been minimized.

Show comment
Hide comment
@netzpirat

netzpirat Aug 15, 2012

Contributor

Sure, I see big advantages in distributed test running and also of Growl over the Mac Notification Center. This is why I don't want this issue to be closed. But I also believe a minority of the Guard users have such a setup and a real need for GNTP (I mean, the rails-dev-box was released 18 hours ago). There are a lot of Guard users that comes from design, frontend development, system administration and also from other languages than Ruby with a simple setup, and for them the growl gem just works fine.

Contributor

netzpirat commented Aug 15, 2012

Sure, I see big advantages in distributed test running and also of Growl over the Mac Notification Center. This is why I don't want this issue to be closed. But I also believe a minority of the Guard users have such a setup and a real need for GNTP (I mean, the rails-dev-box was released 18 hours ago). There are a lot of Guard users that comes from design, frontend development, system administration and also from other languages than Ruby with a simple setup, and for them the growl gem just works fine.

@netzpirat netzpirat closed this in 479d9b9 Sep 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment