Invalid ANSI escape code in Guard::UI #38

Closed
gix opened this Issue Mar 23, 2011 · 4 comments

Comments

Projects
None yet
2 participants
@gix
Contributor

gix commented Mar 23, 2011

Guard::UI.reset_line prints an ESC without further arguments ("\e ") which is, afaik, an invalid escape sequence. This results in literals ESC symbols (showing 001B) when using Guard (in zsh oder bash under Ubuntu here). I'm not sure what the intention behind "\e " is, so I'm not sure whether it should be removed or replaced with something else.

@thibaudgg

This comment has been minimized.

Show comment Hide comment
@thibaudgg

thibaudgg Mar 24, 2011

Owner

Honestly I don't remember why I added this "\e ", maybe the "\r " is enough to reset the line. I will try on my Mac OS X bash when I'll have some time. Feel free to submit a pull request if you think that "\e " is completely useless, thanks!

Owner

thibaudgg commented Mar 24, 2011

Honestly I don't remember why I added this "\e ", maybe the "\r " is enough to reset the line. I will try on my Mac OS X bash when I'll have some time. Feel free to submit a pull request if you think that "\e " is completely useless, thanks!

@gix

This comment has been minimized.

Show comment Hide comment
@gix

gix Mar 24, 2011

Contributor

I presume with "reset_line" is also meant to reset colors/bold etc., not just a carriage return. For that I sent a pull request (see #39).

Contributor

gix commented Mar 24, 2011

I presume with "reset_line" is also meant to reset colors/bold etc., not just a carriage return. For that I sent a pull request (see #39).

@thibaudgg

This comment has been minimized.

Show comment Hide comment
@thibaudgg

thibaudgg Apr 15, 2011

Owner

Now I merged the reset_line issue, do you still have this issue? (Please close this issue if not)

Owner

thibaudgg commented Apr 15, 2011

Now I merged the reset_line issue, do you still have this issue? (Please close this issue if not)

@gix

This comment has been minimized.

Show comment Hide comment
@gix

gix Apr 15, 2011

Contributor

Issue is resolved. Thanks for merging!

Contributor

gix commented Apr 15, 2011

Issue is resolved. Thanks for merging!

@gix gix closed this Apr 15, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment