Allow overriding Emacs notifier options via Guardfile #337

Merged
merged 2 commits into from Oct 10, 2012

Conversation

Projects
None yet
4 participants
Contributor

d1 commented Oct 10, 2012

The first patch allows general overriding of the DEFAULTS options in the emacs notifier.

The second patch adds the ability to override options that don't exist in DEFAULTS. For example, a custom color can be set for 'pending' notifications (instead of just falling back to DEFAULTS[:default]) by providing a :pending option to the notification method.

This allows the Guardfile to look something like:

emacs_colors = {
  :success => 'Green',
  :pending => 'Yellow',
  :failed  => 'Red',
  :default => 'White',
}
notification :emacs, emacs_colors

Please let me know if if there is anything that you'd like to be done differently.

@netzpirat netzpirat merged commit 3de3c84 into guard:master Oct 10, 2012

1 check passed

default The Travis build passed
Details
Contributor

netzpirat commented Oct 10, 2012

Everything is great! Thanks a lot.

Owner

thibaudgg commented Oct 10, 2012

👍 Thanks!

Coverage Status

Coverage decreased (-31.89%) when pulling 3de3c84 on d1:emacs-notifier-options into d011713 on guard:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment