This is a follow up to the Pry pull request #327 and introduces a continuous Pry session, so no stop/start cycle of the interactor on a Guard action anymore. It also cleans up some legacy support code that isn't needed anymore.
Cleanup Pry interactor.
Remove all the interactor start and stop synchronization
and the terminal setting reset completely, just to see
how well Pry does.
Merge branch 'master' into interactor/cleanup
Remove interactor threading code.
This cleans up old thread synchronization
code that is not used anymore with a
continuous Pry session.
I love the way the diffs are shaping up, but I am also having a few issues.
I have one Rails project where, if I require'pry';binding.pry at some point in test execution, the prompt comes up but is in contention with the Guard interactor Pry.
That same project does similarly with pry-rescue/minitest Pries.
I tried to replicate it on a tiny project but it doesn't exhibit the same behavior. Do you see it on your end, or should I bisect these two to figure out what triggers it? Sorry for not doing it right away — am at work and will be busy for next several evenings.
Thanks for the feedback. I've added it to the known issues and will have a look soon.
Redraw interactor prompt after task run.
Since there's no way that bindings.pry would stop the Guard Pry session in another thread, the idea of a continuously running Guard Pry session will never work. So I'm going to abandon this pull request and cherry-pick the good parts.