List plugins embedded in non dedicated gem #373

Merged
merged 1 commit into from Dec 17, 2012

Conversation

Projects
None yet
4 participants
@schmurfy
Contributor

schmurfy commented Dec 11, 2012

It looks like it was easier than I thought !

this change includes in the "guard list" output guard plugins which are not in a "guard-xxx" gem by looking inside the gem folder if a "lib/guard/<gem_name>.rb" file is available.

I only updated the code for rubygems 1.8.0+ since I am not sure about the api provided below.

@thibaudgg

This comment has been minimized.

Show comment Hide comment
@thibaudgg

thibaudgg Dec 12, 2012

Owner

Can you please add some specs, thanks!

Owner

thibaudgg commented Dec 12, 2012

Can you please add some specs, thanks!

@schmurfy

This comment has been minimized.

Show comment Hide comment
@schmurfy

schmurfy Dec 13, 2012

Contributor

specs added !

Contributor

schmurfy commented Dec 13, 2012

specs added !

@thibaudgg

This comment has been minimized.

Show comment Hide comment
@thibaudgg

thibaudgg Dec 13, 2012

Owner

Thanks, @guard/core-team seems good to you?

Owner

thibaudgg commented Dec 13, 2012

Thanks, @guard/core-team seems good to you?

@netzpirat

This comment has been minimized.

Show comment Hide comment
@netzpirat

netzpirat Dec 13, 2012

Contributor

Yes, looks fine for me.

Contributor

netzpirat commented Dec 13, 2012

Yes, looks fine for me.

@rymai

View changes

spec/guard_spec.rb
+ File.should_receive(:exists?).with('/gem1/lib/guard/gem1.rb').and_return(false)
+ File.should_receive(:exists?).with('/gem2/lib/guard/gem2.rb').and_return(true)
+
+ Gem::Specification.should_receive(:find_all).and_return([gem1, gem2])

This comment has been minimized.

Show comment Hide comment
@rymai

rymai Dec 13, 2012

Owner

Shouldn't you return Gem::Specification.should_receive(:find_all).and_return([gem1, gem2, gem3]) here instead?

@rymai

rymai Dec 13, 2012

Owner

Shouldn't you return Gem::Specification.should_receive(:find_all).and_return([gem1, gem2, gem3]) here instead?

This comment has been minimized.

Show comment Hide comment
@schmurfy

schmurfy Dec 13, 2012

Contributor

good catch :)

@schmurfy

schmurfy Dec 13, 2012

Contributor

good catch :)

@rymai

This comment has been minimized.

Show comment Hide comment
@rymai

rymai Dec 13, 2012

Owner

Other than my comment, it seems good to me!

Owner

rymai commented Dec 13, 2012

Other than my comment, it seems good to me!

@schmurfy

This comment has been minimized.

Show comment Hide comment
@schmurfy

schmurfy Dec 13, 2012

Contributor

specs fixed.

Contributor

schmurfy commented Dec 13, 2012

specs fixed.

@thibaudgg

This comment has been minimized.

Show comment Hide comment
@thibaudgg

thibaudgg Dec 17, 2012

Owner

@schmurfy can you try an empty commit to see if travis-ci build are ok now? Thanks!

Owner

thibaudgg commented Dec 17, 2012

@schmurfy can you try an empty commit to see if travis-ci build are ok now? Thanks!

@schmurfy

This comment has been minimized.

Show comment Hide comment
@schmurfy

schmurfy Dec 17, 2012

Contributor

just rebased on master.

Contributor

schmurfy commented Dec 17, 2012

just rebased on master.

@thibaudgg

This comment has been minimized.

Show comment Hide comment
@thibaudgg

thibaudgg Dec 17, 2012

Owner

Great thanks!

Owner

thibaudgg commented Dec 17, 2012

Great thanks!

thibaudgg added a commit that referenced this pull request Dec 17, 2012

Merge pull request #373 from schmurfy/list_embedded
List plugins embedded in non dedicated gem

@thibaudgg thibaudgg merged commit 8883a30 into guard:master Dec 17, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment