Allow options (like :priority) to be passed through to Growl #51

Merged
merged 1 commit into from May 30, 2011

Conversation

Projects
None yet
3 participants
Contributor

indirect commented Apr 29, 2011

This change allows guard plugins (like guard-rspec) to pass options (like :priority) up to the Growl notifier. With this change, things like indirect/rspec-guard@d2f01d69a7aa2d8c4ea01586618f26422680bbf0 are possible, and the growl notification colors can be customized depending on the outcome of the spec run.

Owner

thibaudgg commented Apr 29, 2011

Great, but your commit will break the libnotify notification (https://github.com/guard/guard/blob/master/lib/guard/notifier.rb#L22) because you have removed the title attribute. Please can you fix that and update & add specs. Thanks!

netzpirat merged commit ae1ae1c into guard:master May 30, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment