Allow symbols for group names #73

Merged
merged 2 commits into from Jun 1, 2011

Conversation

Projects
None yet
2 participants
@johnbintz
Member

johnbintz commented Jun 1, 2011

I tried treating Guardfile groups like Gemfile groups by using symbols and that failed. This patch allows the use of symbols in the Guardfile.

@rymai

This comment has been minimized.

Show comment
Hide comment
@rymai

rymai Jun 1, 2011

Member

Can you leave a spec with the guard name set as a String? Thanks, I'll merge after that!

Member

rymai commented Jun 1, 2011

Can you leave a spec with the guard name set as a String? Thanks, I'll merge after that!

@johnbintz

This comment has been minimized.

Show comment
Hide comment
@johnbintz

johnbintz Jun 1, 2011

Member

Will that work?

Member

johnbintz commented Jun 1, 2011

Will that work?

@rymai

This comment has been minimized.

Show comment
Hide comment
@rymai

rymai Jun 1, 2011

Member

Perfect! Does the specs pass? ;)

Member

rymai commented Jun 1, 2011

Perfect! Does the specs pass? ;)

@johnbintz

This comment has been minimized.

Show comment
Hide comment
@johnbintz

johnbintz Jun 1, 2011

Member

All 130 of them.

Member

johnbintz commented Jun 1, 2011

All 130 of them.

rymai pushed a commit that referenced this pull request Jun 1, 2011

@rymai rymai merged commit 53adfc9 into guard:master Jun 1, 2011

@rymai

This comment has been minimized.

Show comment
Hide comment
@rymai

rymai Jun 1, 2011

Member

In that case, let see what Travis-CI has to say! :D

Thanks! :)

Member

rymai commented Jun 1, 2011

In that case, let see what Travis-CI has to say! :D

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment