Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Dependency manager (semi) breaks the darwin adapter. #60

Closed
alloy opened this Issue · 7 comments

4 participants

@alloy

It seems that unless I explicitly require the rb-fsevents gem myself, teh new dependency manager won’t use it, even though it’s installed and available.

If I require the gem explicitly (e.g. through adding it to a Gemfile) it works as expected.

I haven’t looked through all the dependency manager code yet, but judging by the size, I assume it should be doing this by automatically, no?

(Here’s a user reporting it to a repo of mine: alloy/kicker#35)

@thibaudgg
Owner

Normally the gem should be properly required from here.

@alloy

Yeah that does look good, I’ll update here when I have had the time to debug it myself first.

@Maher4Ever
Collaborator

As @thibaudgg already mentioned, the DM already activates a version of a gem (using the gem method) then requires it. I'll be interested to know why it doesn't work in your case.

@taavo

Unless the point of the dependency manager was to get us to add the adapter(s) we need to our Gemfile manually instead of always requiring all three (is it? that doesn't seem wholly unreasonable), I think I'm also experiencing this issue.

rb-fsevent 0.9.2 is installed, but unless I add it to my Gemfile, listen complains as follows:

[Listen warning]:
  Missing dependency 'rb-fsevent' (version '~> 0.9.1')!
  Please add the following to your Gemfile to satisfy the dependency:
    gem 'rb-fsevent', '~> 0.9.1'

  For a better performance, it's recommended that you satisfy the missing dependency.
  Listen will be polling changes. Learn more at https://github.com/guard/listen#polling-fallback.

I'm running 10.8.2, with 1.9.3 on rbenv. Let me know if there's anything I can do to help investigate this issue.

@thibaudgg
Owner

Yeah you need to add it to your Gemfile and use bundle exec. Do you think it's not reasonable?

There is an issue on Guard related to that too: guard/guard#330

@taavo

I can't think of a better way to do it, so no, not unreasonable at all. I wouldn't have thought it was an issue if the documentation were a little clearer as described in guard/guard#330, and if this issue weren't already open. Thanks!

@thibaudgg
Owner

Great, thanks for your feedback. Closed by guard/guard@34a9057

@thibaudgg thibaudgg closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.