Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait_for_delay option #157

Merged
merged 1 commit into from
Oct 29, 2013
Merged

Conversation

itsuryev
Copy link
Contributor

Resolves issue #156

This is totally separate issue but have to note that I was able to successfully run unit tests (even without my changes) only on 1 computer out of 3. And on the second one after increasing sleep time in the acceptence_helper.rb file.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.37%) when pulling 516624e on itsuryev:wait_for_delay-option into e9de0d5 on guard:master.

@thibaudgg
Copy link
Member

Yeah sleep time in the acceptence_helper.rb is always fancy and depends on the system. Which value have you set? (So I can maybe increase it). Thanks!

@itsuryev
Copy link
Contributor Author

0.3 was not enough and 0.5 worked well for me. Haven't tried values in between though.

@thibaudgg
Copy link
Member

Ok thanks!

thibaudgg added a commit that referenced this pull request Oct 29, 2013
@thibaudgg thibaudgg merged commit cfd3f33 into guard:master Oct 29, 2013
@thibaudgg
Copy link
Member

2.2.0 released, thanks!

@itsuryev itsuryev deleted the wait_for_delay-option branch October 29, 2013 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants