Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split paths into watched and relative #235

Merged
merged 2 commits into from
Jun 4, 2014

Conversation

e2
Copy link
Contributor

@e2 e2 commented Jun 4, 2014

Make every path used in Listen separate from work directory.

This is so ultimately watched directories are truly separate and contain their own config.

Implications:

  • every directory could have it's own Record
  • Record uses up less memory
  • silencer can work more reliably (not "hack" to turn path into relative to watched dir)
  • TCP message format is incompatible
  • Record distinguishes files from dirs based on existence of :mtime field
  • Listener config no longer has to be passed down to adapter
  • Silencer no longer includes Celluloid overhead
  • in the future, Record could be turned on/off for specific directories
  • much cleaner debug/output possible (only relative paths)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.61%) when pulling 94ea2cf on split_paths_into_watched_and_relative into 18d5860 on master.

e2 added a commit that referenced this pull request Jun 4, 2014
@e2 e2 merged commit b3b5004 into master Jun 4, 2014
@e2 e2 deleted the split_paths_into_watched_and_relative branch June 4, 2014 21:55
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) when pulling 3036c5f on split_paths_into_watched_and_relative into 18d5860 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants