Use FFI::Library::LIBC in favor of magic "c" constant when calling ffi_lib. #20

Merged
merged 1 commit into from Dec 1, 2012

Conversation

Projects
None yet
4 participants
@mbj
Contributor

mbj commented Jul 30, 2012

  • The current code uses a magic literal constant "c".
    This breaks under my archlinux. I need "libc.so.6".
    The FFI::Library::LIBC constant is especially designed
    to take care on these differences as it delegates to
    FFI::Platform::LIBC that is in my case the "libc.so.6".

I suspect this change will work for other platforms very well.

Markus Schirp
Use more durable FFI::Library::LIBC constant.
* The current code uses a magic literal constant "c".
  This breaks under my archlinux. I need "libc.so.6".
  The FFI::Library::LIBC constant is especially designed
  to take care on these differences as it delegates to
  FFI::Platform::LIBC that is in my case the "libc.so.6".
@Maher4Ever

This comment has been minimized.

Show comment Hide comment
@Maher4Ever

Maher4Ever Aug 4, 2012

I faced the same error on Rubinius: http://travis-ci.org/#!/guard/listen/jobs/2005566.
This patch fixes it.

I faced the same error on Rubinius: http://travis-ci.org/#!/guard/listen/jobs/2005566.
This patch fixes it.

@mbj

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Aug 8, 2012

Contributor

Yeah I had the same error when using the listen gem and tracked it down to rb-inotify :P

Contributor

mbj commented Aug 8, 2012

Yeah I had the same error when using the listen gem and tracked it down to rb-inotify :P

@Maher4Ever

This comment has been minimized.

Show comment Hide comment
@Maher4Ever

Maher4Ever Aug 9, 2012

@mbj Great job fixing this! I was planning to send a pull request with a patch, but you were faster :)
@nex3 Could you consider merging this patch and releasing a new version of rb-inotify?

@mbj Great job fixing this! I was planning to send a pull request with a patch, but you were faster :)
@nex3 Could you consider merging this patch and releasing a new version of rb-inotify?

@mbj

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Aug 9, 2012

Contributor

@Maher4Ever Thx for the kudos.
@nex3 Is there anything else open that forbids a release?

Contributor

mbj commented Aug 9, 2012

@Maher4Ever Thx for the kudos.
@nex3 Is there anything else open that forbids a release?

@mbj

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Sep 10, 2012

Contributor

@Maher4Ever, contacted @nex3 via mail to push this issue to the head of his work-busy queue. Lets cross fingers he has the time to do a release shortly.

Contributor

mbj commented Sep 10, 2012

@Maher4Ever, contacted @nex3 via mail to push this issue to the head of his work-busy queue. Lets cross fingers he has the time to do a release shortly.

@Maher4Ever

This comment has been minimized.

Show comment Hide comment
@Maher4Ever

Maher4Ever Sep 11, 2012

@mbj Awesome man! I can't wait to get this issue fixed :)

@mbj Awesome man! I can't wait to get this issue fixed :)

@mbj

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Nov 6, 2012

Contributor

@Maher4Ever I also tried to contact @nex3 via twitter and did not got a reaction. Most likely he has something better to do. :(

Contributor

mbj commented Nov 6, 2012

@Maher4Ever I also tried to contact @nex3 via twitter and did not got a reaction. Most likely he has something better to do. :(

@mbj

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Nov 17, 2012

Contributor

@nex3 Some reaction is better than none!

Contributor

mbj commented Nov 17, 2012

@nex3 Some reaction is better than none!

@mbj

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Nov 19, 2012

Contributor

@Maher4Ever Any idea to attract attention? I dislike moving around git sources in my Gemfile all the time.
@nex3 You can add me to the gem on rubygems.org if you like, I can do the release for myself.

Contributor

mbj commented Nov 19, 2012

@Maher4Ever Any idea to attract attention? I dislike moving around git sources in my Gemfile all the time.
@nex3 You can add me to the gem on rubygems.org if you like, I can do the release for myself.

@nex3

This comment has been minimized.

Show comment Hide comment
@nex3

nex3 Dec 1, 2012

Collaborator

Sorry everyone, I've been putting off dealing with my smaller project. I'll merge this now and cut a release.

Collaborator

nex3 commented Dec 1, 2012

Sorry everyone, I've been putting off dealing with my smaller project. I'll merge this now and cut a release.

nex3 added a commit that referenced this pull request Dec 1, 2012

Merge pull request #20 from mbj/master
Use FFI::Library::LIBC in favor of magic "c" constant when calling ffi_lib.

@nex3 nex3 merged commit 3255dca into guard:master Dec 1, 2012

@mbj

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Dec 1, 2012

Contributor

@nex3 thx!

Contributor

mbj commented Dec 1, 2012

@nex3 thx!

@dkubb

This comment has been minimized.

Show comment Hide comment
@dkubb

dkubb Jan 1, 2013

@mbj did you submit this patch upstream?

dkubb commented on 3488a84 Jan 1, 2013

@mbj did you submit this patch upstream?

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Jan 1, 2013

Owner

Yeah, was also merged but release is still pending.

Owner

mbj replied Jan 1, 2013

Yeah, was also merged but release is still pending.

This comment has been minimized.

Show comment Hide comment
@dkubb

dkubb Jan 2, 2013

@mbj should we change the dep to point to the other repo with the fix instead of yours?

dkubb replied Jan 2, 2013

@mbj should we change the dep to point to the other repo with the fix instead of yours?

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Jan 2, 2013

Owner

Yeah, I forgot about this. Changed.

Owner

mbj replied Jan 2, 2013

Yeah, I forgot about this. Changed.

@mbj

This comment has been minimized.

Show comment Hide comment
@mbj

mbj Jan 2, 2013

Contributor

@nex3 Kindly reminding you on your promise to do a dot release containing this fix!

//cc @dkubb

EDIT: Spell nick dorrectly

Contributor

mbj commented Jan 2, 2013

@nex3 Kindly reminding you on your promise to do a dot release containing this fix!

//cc @dkubb

EDIT: Spell nick dorrectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment