Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up internet warriors #113

Merged
merged 3 commits into from Mar 13, 2017
Merged

Set up internet warriors #113

merged 3 commits into from Mar 13, 2017

Conversation

duarte
Copy link
Contributor

@duarte duarte commented Feb 22, 2017

Just adds a temporary link for the next doc, Internet Warriors

@duarte duarte requested a review from gidsg February 22, 2017 17:39
@@ -1,5 +1,5 @@
export default function sheetNameFromShortId(docsArray, shortUrl) {
const map = new Map(docsArray);
const docName = map.get(shortUrl);
return docName ? docName : 'gun-nation';
return docName ? docName : 'internet-warriors';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround to the fact that now we are relying on pageId we don't know this until the day of publication, so we default to the latest doc.

Copy link
Contributor

@gidsg gidsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this isn't a perfect solution, but we should make master reflect what is deployed. 👍

@gidsg gidsg merged commit 8beac42 into master Mar 13, 2017
@duarte duarte deleted the set-up-internet-warriors branch March 13, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants