Move ab testing config to ab-testing/config #14882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Jakeii
force-pushed
the
jlk/ab-testing-config-workspace
branch
from
f5bf708 to
7f351c7
Compare
Jakeii
added
the
maintenance
on-ye
approved these changes
Nov 21, 2025
Contributor
on-ye
left a comment
on-ye
left a comment
There was a problem hiding this comment.
I think the separation of workspaces through the pnpm-workspace.yaml file isn't as intuitive as looking at the packages directory, but I guess that's an organisational pattern.
Still, I think this PR is a good step to increased clarity, and potentially moving ab testing to it's own repo
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Create a new directory
ab-testing/configfor the ab testing config code, this in now a workspace directory. andab-testingis no longer a workspace.Why?
There will be some more elements joining the
ab-testingdirectory - lambda and cdk code. This is to avoid workspaces within workspaces.