From b54a3026f0da253eb99ce9be2d27fa7c77797f72 Mon Sep 17 00:00:00 2001 From: vanessa <32312712+vlbee@users.noreply.github.com> Date: Thu, 24 Nov 2022 09:41:06 +0000 Subject: [PATCH 1/2] Delete sign in gate long mandatory AB test --- common/app/conf/switches/ABTestSwitches.scala | 80 ----------- .../common/modules/experiments/ab-tests.ts | 18 --- .../tests/sign-in-gate-mandatory-long.js | 127 ------------------ 3 files changed, 225 deletions(-) delete mode 100644 static/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-mandatory-long.js diff --git a/common/app/conf/switches/ABTestSwitches.scala b/common/app/conf/switches/ABTestSwitches.scala index 108635e1cbd4..c9df59e4e324 100644 --- a/common/app/conf/switches/ABTestSwitches.scala +++ b/common/app/conf/switches/ABTestSwitches.scala @@ -25,86 +25,6 @@ trait ABTestSwitches { exposeClientSide = true, ) - Switch( - ABTests, - "ab-sign-in-gate-mandatory-long-test-control-uk", - "Long mandatory sign in gate trial", - owners = Seq(Owner.withGithub("vlbee")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 1, 31)), - exposeClientSide = true, - ) - - Switch( - ABTests, - "ab-sign-in-gate-mandatory-long-test-control-na", - "Long mandatory sign in gate trial", - owners = Seq(Owner.withGithub("vlbee")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 1, 31)), - exposeClientSide = true, - ) - - Switch( - ABTests, - "ab-sign-in-gate-mandatory-long-test-control-aunz", - "Long mandatory sign in gate trial", - owners = Seq(Owner.withGithub("vlbee")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 1, 31)), - exposeClientSide = true, - ) - - Switch( - ABTests, - "ab-sign-in-gate-mandatory-long-test-control-eu", - "Long mandatory sign in gate trial", - owners = Seq(Owner.withGithub("vlbee")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 1, 31)), - exposeClientSide = true, - ) - - Switch( - ABTests, - "ab-sign-in-gate-mandatory-long-test-variant-uk", - "Long mandatory sign in gate trial", - owners = Seq(Owner.withGithub("vlbee")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 1, 31)), - exposeClientSide = true, - ) - - Switch( - ABTests, - "ab-sign-in-gate-mandatory-long-test-variant-na", - "Long mandatory sign in gate trial", - owners = Seq(Owner.withGithub("vlbee")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 1, 31)), - exposeClientSide = true, - ) - - Switch( - ABTests, - "ab-sign-in-gate-mandatory-long-test-variant-aunz", - "Long mandatory sign in gate trial", - owners = Seq(Owner.withGithub("vlbee")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 1, 31)), - exposeClientSide = true, - ) - - Switch( - ABTests, - "ab-sign-in-gate-mandatory-long-test-variant-eu", - "Long mandatory sign in gate trial", - owners = Seq(Owner.withGithub("vlbee")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 1, 31)), - exposeClientSide = true, - ) - Switch( ABTests, "ab-deeply-read-article-footer", diff --git a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts index 6c2a95d9efd4..8af3777b345a 100644 --- a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts +++ b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts @@ -6,16 +6,6 @@ import { remoteRRHeaderLinksTest } from './tests/remote-header-test'; import { removePrebidA9Canada } from './tests/removePrebidA9Canada'; import { signInGateMainControl } from './tests/sign-in-gate-main-control'; import { signInGateMainVariant } from './tests/sign-in-gate-main-variant'; -import { - signInGateMandatoryLongTestControlAunz, - signInGateMandatoryLongTestControlEu, - signInGateMandatoryLongTestControlNa, - signInGateMandatoryLongTestControlUk, - signInGateMandatoryLongTestVariantAunz, - signInGateMandatoryLongTestVariantEu, - signInGateMandatoryLongTestVariantNa, - signInGateMandatoryLongTestVariantUk, -} from './tests/sign-in-gate-mandatory-long'; // keep in sync with ab-tests in dotcom-rendering // https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/web/experiments/ab-tests.ts @@ -26,13 +16,5 @@ export const concurrentTests: readonly ABTest[] = [ deeplyReadArticleFooterTest, consentlessAds, integrateIma, - signInGateMandatoryLongTestControlAunz, - signInGateMandatoryLongTestControlEu, - signInGateMandatoryLongTestControlNa, - signInGateMandatoryLongTestControlUk, - signInGateMandatoryLongTestVariantAunz, - signInGateMandatoryLongTestVariantNa, - signInGateMandatoryLongTestVariantEu, - signInGateMandatoryLongTestVariantUk, removePrebidA9Canada, ]; diff --git a/static/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-mandatory-long.js b/static/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-mandatory-long.js deleted file mode 100644 index 5bf4c210c3d6..000000000000 --- a/static/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-mandatory-long.js +++ /dev/null @@ -1,127 +0,0 @@ -const sharedTestData = { - start: '2022-10-11', - expiry: '2023-01-31', - author: 'vlbee', - description: - 'Long-running mandatory sign in gate - Show gate to global users on 3rd article view of simple article templates, with higher priority over banners and epic.', - audienceCriteria: - 'Restricted by region, 3rd article of the day, lower priority than consent banner, simple articles (not gallery, live etc.), not signed in, not shown after dismiss, not on help, info sections etc. Exclude iOS 9 and guardian-live-australia. Suppresses other banners, and appears over epics', - successMeasure: - 'Primary metric will be the average attention time per browser. Secondary: Average page views per browser, Sessions per browser, Gate conversion rate, Average days between visits, Engagement score, Reader revenue, Programmatic ad revenue', - idealOutcome: - 'Significantly grow the number of registered and signed in users amongst this cohort, with appropriate permissions but achieve this without meaningfully denting engagement with our journalism or long-term ad revenue', - showForSensitive: false, - canRun: () => false, -}; - -export const signInGateMandatoryLongTestControlUk = { - ...sharedTestData, - id: 'SignInGateMandatoryLongTestControlUk', - audience: 0.0393, - audienceOffset: 0, - dataLinkNames: 'SignInGateMandatoryLongTestControlUk', - variants: [ - { - id: 'mandatory-long-test-control-uk', - test: () => {}, - }, - ], -}; - -export const signInGateMandatoryLongTestVariantUk = { - ...sharedTestData, - id: 'SignInGateMandatoryLongTestVariantUk', - audience: 0.0182, - audienceOffset: 0.8373, - dataLinkNames: 'SignInGateMandatoryLongTestVariantUk', - variants: [ - { - id: 'mandatory-long-test-variant-uk', - test: () => {}, - }, - ], -}; - -export const signInGateMandatoryLongTestControlNa = { - ...sharedTestData, - id: 'SignInGateMandatoryLongTestControlNa', - audience: 0.1131, - audienceOffset: 0, - dataLinkNames: 'SignInGateMandatoryLongTestControlNa', - variants: [ - { - id: 'mandatory-long-test-control-na', - test: () => {}, - }, - ], -}; - -export const signInGateMandatoryLongTestVariantNa = { - ...sharedTestData, - id: 'SignInGateMandatoryLongTestVariantNa', - audience: 0.0544, - audienceOffset: 0.8373, - dataLinkNames: 'SignInGateMandatoryLongTestVariantNa', - variants: [ - { - id: 'mandatory-long-test-variant-na', - test: () => {}, - }, - ], -}; - -export const signInGateMandatoryLongTestControlAunz = { - ...sharedTestData, - id: 'SignInGateMandatoryLongTestControlAunz', - audience: 0.1254, - audienceOffset: 0, - dataLinkNames: 'SignInGateMandatoryLongTestControlAunz', - variants: [ - { - id: 'mandatory-long-test-control-aunz', - test: () => {}, - }, - ], -}; - -export const signInGateMandatoryLongTestVariantAunz = { - ...sharedTestData, - id: 'SignInGateMandatoryLongTestVariantAunz', - audience: 0.0627, - audienceOffset: 0.8373, - dataLinkNames: 'SignInGateMandatoryLongTestVariantAunz', - variants: [ - { - id: 'mandatory-long-test-variant-aunz', - test: () => {}, - }, - ], -}; - -export const signInGateMandatoryLongTestControlEu = { - ...sharedTestData, - id: 'SignInGateMandatoryLongTestControlEu', - audience: 0.0773, - audienceOffset: 0, - dataLinkNames: 'SignInGateMandatoryLongTestControlEu', - variants: [ - { - id: 'mandatory-long-test-control-eu', - test: () => {}, - }, - ], -}; - -export const signInGateMandatoryLongTestVariantEu = { - ...sharedTestData, - id: 'SignInGateMandatoryLongTestVariantEu', - audience: 0.0365, - audienceOffset: 0.8373, - dataLinkNames: 'SignInGateMandatoryLongTestVariantEu', - variants: [ - { - id: 'mandatory-long-test-variant-eu', - test: () => {}, - }, - ], -}; From e436334c012f4c62f2829de45815b38b9afd09c8 Mon Sep 17 00:00:00 2001 From: vanessa <32312712+vlbee@users.noreply.github.com> Date: Thu, 24 Nov 2022 10:17:46 +0000 Subject: [PATCH 2/2] Revert main sign in gate audience numbers --- .../modules/experiments/tests/sign-in-gate-main-variant.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/static/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-main-variant.js b/static/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-main-variant.js index 3493e3bcb2ac..989933dfa275 100644 --- a/static/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-main-variant.js +++ b/static/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-main-variant.js @@ -8,8 +8,8 @@ export const signInGateMainVariant = { author: 'Mahesh Makani', description: 'Show sign in gate to 100% of users on 3rd article view of simple article templates, with higher priority over banners and epic. Main/Variant Audience.', - audience: 0.7119, - audienceOffset: 0.1254, + audience: 0.9, + audienceOffset: 0.0, successMeasure: 'Users sign in or create a Guardian account', audienceCriteria: '3rd article of the day, lower priority than consent banner, simple articles (not gallery, live etc.), not signed in, not shown after dismiss, not on help, info sections etc. Exclude iOS 9 and guardian-live-australia. Suppresses other banners, and appears over epics',