Use front type to determine rendering of paid containers #11932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using view helper method.
Whether to render a paid container as a paid container or not.
| def shouldRenderAsCommercialContainer(frontPriority: Option[FrontPriority], container: FaciaContainer): Boolean = { | ||
| Switches.NewCommercialContent.isSwitchedOn && | ||
| Switches.PaidContainerUpdate.isSwitchedOn && | ||
| frontPriority.contains(EditorialPriority) && |
There was a problem hiding this comment.
Everything is using scala 2.11 so safe to use an Option.contains.
|
Looks good - can expand to Dynamic containers once happy with Fixed containers. |
kelvin-chappell
added a commit
that referenced
this pull request
Feb 12, 2016
Use front type to determine rendering of paid containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want paid containers to have the new styling if they appear on editorial fronts.
This change uses the
ConfigAgentto determine the type of front the container is on./cc @janua