Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Reduce image weight, welcome hidpi screens #12079
What does this change?
Updates imgix settings, based on @paperboyo's reseach:
It turns out you can drop the
What is the value of this and can you measure success?
Reduces image payload while improving or maintaining quality. The actual saving depends on browser capabilities and the content of the images, but for the current UK network front, desktop breakpoint:
As mentioned above,
Screenshots (hidpi only)
Non-hidpi look near enough identical.
Differences in these hidpi screenshots won't really be noticeable on non-hidpi screens…
Enormous thanks goes to @sndrs who did all the work! And had to put up with me.
I would love, pretty please, for that to be accompanied in some foreseeable future with an adjustment to how we display images in the Lightbox (because this will affect them). After this goes out, if image will be smaller than Lighbox'es viewport, it will sit at the top not stretched to fill full width looking silly (currently the lack of
How can we measure average daily bandwidth savings, d'you think? Or whatever would be the nicest-looking stat? :)
(EDIT: issue opened: #12215)
In the best tradition of my not-PR-related comments, there is much more optimisation we might want to do to Lightbox, e.g.:
weights 3,7MB and measures 2872px vertically on my 2560x1600 monitor ([EDIT somehow Lightbox is
Awesome! Good description of the change :-)
I made a table to help me understand how and when we vary
Scala looks mighty fine to me