Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated accessibility checking #16587

Merged
merged 3 commits into from May 2, 2017

Conversation

Projects
None yet
4 participants
@gustavpursche
Copy link
Contributor

commented Apr 28, 2017

What does this change?

This adds Pa11y for automated accessibility testing. Currently we only want to trigger this step manually or via the PRbuilds. This is the first step to resolve existing problems, so that we can easily monitor newly introduced problems later on.

What is the value of this and can you measure success?

Hopefully better accessibility in the future. More automated checking in order to detect problems at an earlier stage.

Does this affect other platforms - Amp, Apps, etc?

No.

Screenshots

screen shot 2017-04-28 at 11 32 53

Tested in CODE?

No.

@gustavpursche gustavpursche requested review from SiAdcock, katebee and sndrs Apr 28, 2017

@PRBuilds

This comment has been minimized.

Copy link

commented Apr 28, 2017

PR build results:

screenshots
mobile.pngwide.pngtablet.pngdesktop.png

exceptions (0)
thrown-exceptions.js

webpagetest (3)
performanceComparisonSummary.txt

-automated message

@SiAdcock
Copy link
Contributor

left a comment

This looks awesome, nice one!

@gustavpursche gustavpursche merged commit b01622e into master May 2, 2017

1 check passed

continuous-integration/teamcity Finished TeamCity Build dotcom :: frontend : Tests passed: 1810, ignored: 1
Details

@gustavpursche gustavpursche deleted the gp-pa11y-integration branch May 2, 2017

@prout-bot

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2017

Seen on PROD (merged by @gustavpursche 12 minutes and 57 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.