New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor identity bugfix] prevent recursive urlencoding #18428

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
4 participants
@walaura
Contributor

walaura commented Dec 7, 2017

What does this change?

redirectWithReturn() was redundantly urlencoding the returnUrl one time too many (since appendQueryParams already encodes the parameters), potentially breaking it

@PRBuilds

This comment has been minimized.

Show comment
Hide comment
@PRBuilds

PRBuilds Dec 7, 2017

PRbuilds results:

Screenshots
desktop.pngtablet.pngmobile.pngwide.png

💚 Exceptions
thrown-exceptions.js

💚 A11y validation
a11y-report.txt

Apache Benchmark Load Testing
loadtesting.txt

💚 Microdata Validation
microdata.txt

--automated message

PRBuilds commented Dec 7, 2017

PRbuilds results:

Screenshots
desktop.pngtablet.pngmobile.pngwide.png

💚 Exceptions
thrown-exceptions.js

💚 A11y validation
a11y-report.txt

Apache Benchmark Load Testing
loadtesting.txt

💚 Microdata Validation
microdata.txt

--automated message

@walaura walaura merged commit ffa52be into master Dec 7, 2017

1 check passed

continuous-integration/teamcity Finished TeamCity Build dotcom :: frontend : Tests passed: 1807
Details

@walaura walaura deleted the bugfix-double-urlencode branch Dec 7, 2017

@prout-bot

This comment has been minimized.

Show comment
Hide comment
@prout-bot

prout-bot Dec 7, 2017

Collaborator

Seen on PROD (merged by @walaura 14 minutes and 49 seconds ago)

Collaborator

prout-bot commented Dec 7, 2017

Seen on PROD (merged by @walaura 14 minutes and 49 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment