Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix crossword input validation #20733
What does this change?
This improves how accented characters and numbers are handled in crosswords by:
What is the value of this and can you measure success?
Currently certain crosswords are uncompletable. This can be unfulfilling for anyone trying to solve them. Others have seen this too, for example, there's a few comments about it on a recent weekend crossword.
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Accessibility test checklist
I've worked on extracting the crossword component which has made it easier for me to work on these fixes independently of the rest of the frontend codebase. I've been able to run tests & linters for the isolated component and test it in browser to give me the confidence that this fixes the issue.
I've read that certain contributions require a signed CLA as I'm an external contributor. Please let me know if this is required since I'm happy to do this.
Hey @zetter this is great.
We're really happy that you've also taken the time to extract the component into its own codebase. I guess we should probably consider whether it should have its own codebase and package instead of living in the frontend repo.
N.B. I pulled this branch and pushed it to frontend to build it on teamcity, but it needed rebasing against master. I'm not sure how that build got associated with this PR and the post rebase one didn't. I deployed the rebased branch on CODE and it's AOK 👌🏻
tldr: this builds and deploys okay