Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump capi client to 16.0 #22285

Merged
merged 2 commits into from Feb 12, 2020
Merged

Bump capi client to 16.0 #22285

merged 2 commits into from Feb 12, 2020

Conversation

@JustinPinner
Copy link
Member

JustinPinner commented Feb 11, 2020

What does this change?

Updates CAPI client library to 16.0 (guardian/content-api-scala-client@968af16)

Does this change need to be reproduced in dotcom-rendering ?

  • No (unless DCR has another version of the client squirrelled away somewhere)
  • Yes (please indicate your plans for DCR Implementation)

Screenshots

N/A (everything looks the same)

What is the value of this and can you measure success?

It'll let the CAPI team monitor the backoff and retry behaviour of the client library. We will be able to see when retries happen, and from that figure out if the failure codes we're retrying are appropriate and whether the retry mechanism really is helping when we're experiencing some instability in our Concierge application.

Checklist

Does this affect other platforms?

  • AMP
  • Apps
  • Other (CAPI)

Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?

  • No
  • Yes (please give details)

Does this change break ad-free?

  • No
  • It did, but tests caught it and I fixed it
  • It did, but there was no test coverage so I added that then fixed it

Does this change update the version of CAPI we're using?

Accessibility test checklist

Tested

  • Locally
  • On CODE (when this builds)
@PRBuilds

This comment has been minimized.

Copy link

PRBuilds commented Feb 11, 2020

PRbuilds results:

Screenshots
wide.pngdesktop.pngtablet.pngmobile.png

💚 A11y validation
a11y-report.txt

💚 Microdata Validation
microdata.txt

Apache Benchmark Load Testing
loadtesting.txt

LightHouse Reporting
1581504252.report.html

--automated message

@JustinPinner

This comment has been minimized.

Copy link
Member Author

JustinPinner commented Feb 12, 2020

157 of the 158 files changed are database files - sorry 🙄

Copy link
Member

gtrufitt left a comment

I updated the description to include link to release details, otherwise 👍

@JustinPinner

This comment has been minimized.

Copy link
Member Author

JustinPinner commented Feb 12, 2020

Thanks @gtrufitt - merging now...

@JustinPinner JustinPinner merged commit b0fafee into master Feb 12, 2020
15 checks passed
15 checks passed
continuous-integration/teamcity Finished TeamCity Build dotcom / frontend : Tests passed: 2145, ignored: 2
Details
license/snyk - admin/pom.xml (guardian-frontend) No new issues
Details
license/snyk - build.sbt (guardian-frontend) No manifest changes detected
license/snyk - dev/eslint-plugin-guardian-frontend/package.json (guardian-frontend) No manifest changes detected
license/snyk - identity/build.sbt (guardian-frontend) No manifest changes detected
license/snyk - package.json (guardian-frontend) No manifest changes detected
license/snyk - sport/pom.xml (guardian-frontend) No new issues
Details
license/snyk - tools/amp-validation/package.json (guardian-frontend) No manifest changes detected
security/snyk - admin/pom.xml (guardian-frontend) No new issues
Details
security/snyk - build.sbt (guardian-frontend) No manifest changes detected
security/snyk - dev/eslint-plugin-guardian-frontend/package.json (guardian-frontend) No manifest changes detected
security/snyk - identity/build.sbt (guardian-frontend) No manifest changes detected
security/snyk - package.json (guardian-frontend) No manifest changes detected
security/snyk - sport/pom.xml (guardian-frontend) No new issues
Details
security/snyk - tools/amp-validation/package.json (guardian-frontend) No manifest changes detected
@prout-bot

This comment has been minimized.

Copy link
Collaborator

prout-bot commented Feb 12, 2020

Seen on PROD (merged by @JustinPinner 14 minutes and 23 seconds ago)

@shtukas shtukas deleted the jp-capi-client-16.0 branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.