Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Fixes #489 #490

Merged
merged 4 commits into from Mar 2, 2017
Merged

Fixes #489 #490

merged 4 commits into from Mar 2, 2017

Conversation

danburzo
Copy link
Contributor

@danburzo danburzo commented Jul 22, 2016

This pull request fixes some issues identified in #489 for inline-mode:

Pressing Enter while having a selection originally did not delete the range contents. It now does.

Pressing Enter in the middle of a word would insert two <br> elements between the parts. I've changed the hasContent method such that it takes into consideration text nodes that have non-whitespace content. (created a new nodeHelpers method + related tests).

I've also added a raw-inline.html example for fiddling with inline-mode Scribe.

@danburzo
Copy link
Contributor Author

I've also included a sanity check for scribe.el.lastChild. Scribe assumes the element always has some child, but there are situations when the element gets completely empty. Pressing Enter in these situations will throw an error.

@rrees
Copy link
Contributor

rrees commented Feb 3, 2017

Looks good 👍

@codeclown
Copy link

codeclown commented Feb 24, 2017

Just noticed this too. When would this be available in the release?

@katebee katebee merged commit e11ecb0 into guardian:master Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants