Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dev-nginx for setting up nginx in DEV #1867

Merged
merged 3 commits into from Jun 18, 2019

Conversation

Projects
None yet
3 participants
@akash1810
Copy link
Member

commented Jun 7, 2019

Why are you doing this?

dev-nginx contains a number of generic useful scripts to:

  • issue certs locally (and automatically trust them)
  • edit hosts file
  • symlink nginx configs
  • restart nginx

Using dev-nginx means:

  • we're creating certificates locally, valid only to a single machine
  • we do not need to update certs every year as they expire (#1355), we just need to re-run the script when certs expire
  • we do not need an S3 bucket holding certs for local dev

Depends on:

We probably could move to using setup-app too, removing the support.conf file. However it's probably best to make small changes.

Trello Card

Changes

  • Change 1 - erm, see above?
  • Change 2 - see change 1

Screenshots

n/a

use dev-nginx for setting up nginx in DEV
dev-nginx contains a number of generic useful scripts to:
- issue certs locally (and automatically trust them)
- edit hosts file
- symlink nginx configs
- restart nginx

Using dev-nginx means:
- we're creating certificates locally, valid only to a single machine
- we do not need to update certs every year as they expire (#1355), we just need to re-run the script when certs expire
- we do not need an S3 bucket holding certs for local dev

@akash1810 akash1810 force-pushed the aa-dev-nginx branch from 4d53e31 to 8d2dfb3 Jun 7, 2019

no need to add to hosts file
*.thegulocal.com has been updated in DNS to resolve to 127.0.0.1

@rupertbates rupertbates self-requested a review Jun 10, 2019

@rupertbates
Copy link
Member

left a comment

Looks good, thanks for doing this. Is there a way to use these tools on Linux?

@akash1810

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

Looks good, thanks for doing this. Is there a way to use these tools on Linux?

Yep, so long as dev-nginx/bin is on your PATH. Maybe we should include explicit instructions in the dev-nginx README for how to install mkcert on Linux?

Update: guardian/dev-nginx#8

Update setup.sh
fail fast

@akash1810 akash1810 merged commit 84aa2bb into master Jun 18, 2019

3 checks passed

continuous-integration/teamcity Finished TeamCity Build MemSub / Support / support-frontend-mono : Running
Details
license/snyk - build.sbt (guardian-reader-revenue) No manifest changes detected
security/snyk - build.sbt (guardian-reader-revenue) No manifest changes detected

@akash1810 akash1810 deleted the aa-dev-nginx branch Jun 18, 2019

@prout-bot

This comment has been minimized.

Copy link

commented Jun 18, 2019

Overdue on PROD (merged by @akash1810 14 minutes and 3 seconds ago) What's gone wrong?

@prout-bot

This comment has been minimized.

Copy link

commented Jun 18, 2019

Seen on PROD (merged by @akash1810 14 minutes and 55 seconds ago)

Sentry Release: support-client-side, support

@prout-bot

This comment has been minimized.

Copy link

commented Jun 18, 2019

Testing in PROD passed! Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.