Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test coverage for tag lookup cache and tag sync and fixing blocking level serialisation #366

Conversation

@mkuzdowicz
Copy link
Contributor

commented Sep 4, 2019

What was done here:

  • Adding test coverage for tag lookup cache
  • Adding test coverage for tag sync
  • fixing blocking level serialisation bug
Copy link
Member

left a comment

a minor comment, generally LGTM

@sihil
sihil approved these changes Sep 6, 2019
Copy link
Member

left a comment

This looks good. One suggestion to reduce enum boilerplate but it introduces another dependency.

app/model/BlockingLevel.scala Show resolved Hide resolved
@mkuzdowicz mkuzdowicz merged commit f85930e into master Sep 9, 2019
4 checks passed
4 checks passed
license/snyk - build.sbt (guardian-ed-tools) No manifest changes detected
license/snyk - package.json (guardian-ed-tools) No manifest changes detected
security/snyk - build.sbt (guardian-ed-tools) No manifest changes detected
security/snyk - package.json (guardian-ed-tools) No manifest changes detected
@mkuzdowicz mkuzdowicz deleted the adding-test-coverage-for-TagLookupCache-and-TagSync-and-fxing-BlockingLevel-serialisation branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.