This repository has been archived by the owner. It is now read-only.

XEP-0198 implementation #116

Merged
merged 2 commits into from Mar 26, 2012

Conversation

Projects
None yet
3 participants
@devrandom
Copy link
Member

devrandom commented Mar 8, 2012

First pass at XEP-0198 support. Requires matching asmack patch.

@n8fr8

This comment has been minimized.

Copy link
Member

n8fr8 commented Mar 14, 2012

It is now merged into the "v8" branch, and build is here:
https://github.com/guardianproject/Gibberbot/Gibberbot-debug-v8-alpha-20120313.apk/qr_code

How do we go about testing this now?

@devrandom

This comment has been minimized.

Copy link
Member Author

devrandom commented Mar 14, 2012

You can try sending messages to Gibberbot while killing its net connection (e.g. put it into Airplane mode within a second). Once you restore the connection, the missed message should be received after Gibberbot re-establishes.

@n8fr8

This comment has been minimized.

Copy link
Member

n8fr8 commented Mar 14, 2012

Okay, now it is merged into the v8 branch:
7c22da2

will be testing some more tonight. haven't seen the NULL error yet.

@n8fr8

This comment has been minimized.

Copy link
Member

n8fr8 commented Mar 15, 2012

When testing this between Pidgin and Gibberbot within OTR enabled, I get a "Error setting up private conversation: Bad signature" on the Pidgin side. Gibberbot can decrypt the message, but when I send back a message, that is what Pidgin reports.

Is it possible that the additional attributes you are adding to the messages in the XmppStreamHandler for XEP are somehow invalidating the OTR signatures?

@devrandom

This comment has been minimized.

Copy link
Member Author

devrandom commented Mar 15, 2012

This is puzzling, because the XEP-0198 stuff is in separate tags, outside of any message. I will dig into it tonight and/or tomorrow.

@n8fr8

This comment has been minimized.

Copy link
Member

n8fr8 commented Mar 16, 2012

I am going to rollback pre this commit and see if it is an issue in my updates.

@n8fr8

This comment has been minimized.

Copy link
Member

n8fr8 commented Mar 16, 2012

Either the issue was related to the state of my local app (corrupted key storage?) or I have some how otherwise resolved it, because it is fine now. Will do more thorough testing, but at this point, I do not believe it is your problem.

@devrandom

This comment has been minimized.

Copy link
Member Author

devrandom commented Mar 20, 2012

For the record, now testing against mod_smacks from the prosody-modules mercurial repository, version 625:2c07bcf56a36.

Version 428 had issues.

@n8fr8 n8fr8 merged commit 4177009 into guardianproject:master Mar 26, 2012

@elhelow

This comment has been minimized.

Copy link

elhelow commented Sep 16, 2015

Hello Dear,
How i can get new element inside item in xmpp android?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.